Remove unnecessary @JvmStatic
except JNI
Because every code is written in kotlin, so we don't need it
Bug: 383243644
Test: Terminal test
Change-Id: I54998aafa14a5ff7542ed36d8ae31d5fa95c2d1e
diff --git a/android/TerminalApp/java/com/android/virtualization/terminal/CertificateUtils.kt b/android/TerminalApp/java/com/android/virtualization/terminal/CertificateUtils.kt
index 53809e5..ee8a8f8 100644
--- a/android/TerminalApp/java/com/android/virtualization/terminal/CertificateUtils.kt
+++ b/android/TerminalApp/java/com/android/virtualization/terminal/CertificateUtils.kt
@@ -39,7 +39,6 @@
object CertificateUtils {
private const val ALIAS = "ttyd"
- @JvmStatic
fun createOrGetKey(): KeyStore.PrivateKeyEntry {
try {
val ks = KeyStore.getInstance("AndroidKeyStore")
@@ -87,7 +86,6 @@
kpg.generateKeyPair()
}
- @JvmStatic
fun writeCertificateToFile(context: Context, cert: Certificate) {
val certFile = File(context.getFilesDir(), "ca.crt")
try {
diff --git a/android/TerminalApp/java/com/android/virtualization/terminal/ErrorActivity.kt b/android/TerminalApp/java/com/android/virtualization/terminal/ErrorActivity.kt
index f253f86..0a1090d 100644
--- a/android/TerminalApp/java/com/android/virtualization/terminal/ErrorActivity.kt
+++ b/android/TerminalApp/java/com/android/virtualization/terminal/ErrorActivity.kt
@@ -58,7 +58,6 @@
companion object {
private const val EXTRA_CAUSE = "cause"
- @JvmStatic
fun start(context: Context, e: Exception) {
val intent = Intent(context, ErrorActivity::class.java)
intent.putExtra(EXTRA_CAUSE, e)
diff --git a/android/TerminalApp/java/com/android/virtualization/terminal/ImageArchive.kt b/android/TerminalApp/java/com/android/virtualization/terminal/ImageArchive.kt
index 86d9db6..017ff89 100644
--- a/android/TerminalApp/java/com/android/virtualization/terminal/ImageArchive.kt
+++ b/android/TerminalApp/java/com/android/virtualization/terminal/ImageArchive.kt
@@ -141,7 +141,6 @@
private const val BUILD_TAG = "latest" // TODO: use actual tag name
private const val HOST_URL = "https://dl.google.com/android/ferrochrome/$BUILD_TAG"
- @JvmStatic
fun getSdcardPathForTesting(): Path {
return Environment.getExternalStoragePublicDirectory(DIR_IN_SDCARD).toPath()
}
@@ -149,7 +148,6 @@
/**
* Creates ImageArchive which is located in the sdcard. This archive is for testing only.
*/
- @JvmStatic
fun fromSdCard(): ImageArchive {
return ImageArchive(getSdcardPathForTesting().resolve(ARCHIVE_NAME))
}
@@ -157,7 +155,6 @@
/**
* Creates ImageArchive which is hosted in the Google server. This is the official archive.
*/
- @JvmStatic
fun fromInternet(): ImageArchive {
val arch =
if (listOf<String?>(*Build.SUPPORTED_ABIS).contains("x86_64")) "x86_64"
@@ -174,7 +171,6 @@
* Creates ImageArchive from either SdCard or Internet. SdCard is used only when the build
* is debuggable and the file actually exists.
*/
- @JvmStatic
fun getDefault(): ImageArchive {
val archive = fromSdCard()
return if (Build.isDebuggable() && archive.exists()) {
diff --git a/android/TerminalApp/java/com/android/virtualization/terminal/InstalledImage.kt b/android/TerminalApp/java/com/android/virtualization/terminal/InstalledImage.kt
index f0447cf..5987859 100644
--- a/android/TerminalApp/java/com/android/virtualization/terminal/InstalledImage.kt
+++ b/android/TerminalApp/java/com/android/virtualization/terminal/InstalledImage.kt
@@ -141,7 +141,6 @@
const val RESIZE_STEP_BYTES: Long = 4 shl 20 // 4 MiB
/** Returns InstalledImage for a given app context */
- @JvmStatic
fun getDefault(context: Context): InstalledImage {
val installDir = context.getFilesDir().toPath().resolve(INSTALL_DIRNAME)
return InstalledImage(installDir)
diff --git a/android/TerminalApp/java/com/android/virtualization/terminal/Logger.kt b/android/TerminalApp/java/com/android/virtualization/terminal/Logger.kt
index 3a273ec..547f1a7 100644
--- a/android/TerminalApp/java/com/android/virtualization/terminal/Logger.kt
+++ b/android/TerminalApp/java/com/android/virtualization/terminal/Logger.kt
@@ -37,7 +37,6 @@
* Forwards VM's console output to a file on the Android side, and VM's log output to Android logd.
*/
internal object Logger {
- @JvmStatic
fun setup(vm: VirtualMachine, path: Path, executor: ExecutorService) {
if (vm.config.debugLevel != VirtualMachineConfig.DEBUG_LEVEL_FULL) {
return
diff --git a/android/TerminalApp/java/com/android/virtualization/terminal/PortsStateManager.kt b/android/TerminalApp/java/com/android/virtualization/terminal/PortsStateManager.kt
index c5335ac..20bccc2 100644
--- a/android/TerminalApp/java/com/android/virtualization/terminal/PortsStateManager.kt
+++ b/android/TerminalApp/java/com/android/virtualization/terminal/PortsStateManager.kt
@@ -121,7 +121,6 @@
private var instance: PortsStateManager? = null
- @JvmStatic
@Synchronized
fun getInstance(context: Context): PortsStateManager {
if (instance == null) {
diff --git a/android/TerminalApp/java/com/android/virtualization/terminal/Runner.kt b/android/TerminalApp/java/com/android/virtualization/terminal/Runner.kt
index 55268f8..6454cbd 100644
--- a/android/TerminalApp/java/com/android/virtualization/terminal/Runner.kt
+++ b/android/TerminalApp/java/com/android/virtualization/terminal/Runner.kt
@@ -59,7 +59,6 @@
companion object {
/** Create a virtual machine of the given config, under the given context. */
- @JvmStatic
@Throws(VirtualMachineException::class)
fun create(context: Context, config: VirtualMachineConfig): Runner {
// context may already be the app context, but calling this again is not harmful.
diff --git a/android/TerminalApp/java/com/android/virtualization/terminal/VmLauncherService.kt b/android/TerminalApp/java/com/android/virtualization/terminal/VmLauncherService.kt
index 966c4a6..8c0368d 100644
--- a/android/TerminalApp/java/com/android/virtualization/terminal/VmLauncherService.kt
+++ b/android/TerminalApp/java/com/android/virtualization/terminal/VmLauncherService.kt
@@ -313,7 +313,6 @@
return Intent(context.getApplicationContext(), VmLauncherService::class.java)
}
- @JvmStatic
fun run(
context: Context,
callback: VmLauncherServiceCallback?,
@@ -345,7 +344,6 @@
return ResultReceiver.CREATOR.createFromParcel(parcel).also { parcel.recycle() }
}
- @JvmStatic
fun stop(context: Context) {
val i = getMyIntent(context)
i.setAction(ACTION_STOP_VM_LAUNCHER_SERVICE)