commit f03d81ad627422f37b5b4e2fb9a7d27d575d82b5
author Alan Stokes <alanstokes@google.com> Mon Sep 20 17:44:03 2021 +0100
committer Alan Stokes <alanstokes@google.com> Tue Sep 21 16:57:16 2021 +0100
tree be007c21fa4f59c2ea50684dfc4699e463e8dd01
parent e7e732af6c3a7ebf65d24dcb530d8f20f329533e

Assorted client fixes.

The most important change is to ensure we hold a reference to
IVirtualizationService to stop the service manager killing the service
process. (I had thought holding the IVirtualMachine would suffice, but
it doesn't.)

Also added code to send the VM's stdout/stderr to the host log, and
modified compsvc to log to stderr instead of the VM log (so we can see
it). I made this a command line arg since we don't always want it.

One downside is that it causes compsvc to crash if nothing is reading
from stderr (broken pipe); as a workaround I've changed the tests to
use a config that doesn't enable it. (This is because we're using "vm
--daemonize" to start the VM; we should maybe stop doing that.)

Also made some tweaks to the client connection code - with the aim of
encapsulating all the unsafe code into one class (which hopefully will
eventually be extracted to a library somewhere), so it is easy to
reason about.

Bug: 186126194
Test: manually run compos_verify_key
Test: atest -p
Change-Id: Icdfc795215b236f0148e93cab34e2f6a0420a933