commit 87751bba76c1a1f8aa170add757b26fb82f8d3cc
author Inseob Kim <inseob@google.com> Thu Feb 24 19:21:00 2022 +0900
committer Inseob Kim <inseob@google.com> Wed Mar 02 09:52:14 2022 +0900
tree b380af1d0e599a1d775f7495dfb8e5a262677b12
parent b3c8bf85dd05e97c8f609695cd2ccfcd44f9da22

Split instance.img compromise tests

For better readability.

Bug: 218461230
Test: atest MicrodroidTests
Change-Id: I80116b978f520092dc1f6e1c9ecbe889fd62d569

tests/testapk/src/java/com/android/microdroid/test/MicrodroidTests.java

diff --git a/tests/testapk/src/java/com/android/microdroid/test/MicrodroidTests.java b/tests/testapk/src/java/com/android/microdroid/test/MicrodroidTests.java
index 27e1846..334f556 100644
--- a/tests/testapk/src/java/com/android/microdroid/test/MicrodroidTests.java
+++ b/tests/testapk/src/java/com/android/microdroid/test/MicrodroidTests.java
@@ -486,13 +486,9 @@
         return payloadStarted.getNow(false);
     }
 
-    @Test
-    public void bootFailsWhenInstanceDiskIsCompromised()
+    // Flips a bit of given partition, and then see if boot fails. The partition must exist.
+    private void tryCompromisingInstanceDiskPartition(UUID partitionUuid)
             throws VirtualMachineException, InterruptedException, IOException {
-        assume().withMessage("Skip on Cuttlefish. b/195765441")
-                .that(android.os.Build.DEVICE)
-                .isNotEqualTo("vsoc_x86_64");
-
         VirtualMachineConfig config = mInner.newVmConfigBuilder("assets/vm_config.json")
                 .debugLevel(DebugLevel.NONE)
                 .build();
@@ -511,17 +507,51 @@
         File instanceImgPath = new File(vmDir, "instance.img");
         RandomAccessFile instanceFile = new RandomAccessFile(instanceImgPath, "rw");
 
-        // partitions may or may not exist
-        for (UUID uuid :
-                new UUID[] {
-                    MICRODROID_PARTITION_UUID, U_BOOT_AVB_PARTITION_UUID, U_BOOT_ENV_PARTITION_UUID
-                }) {
-            OptionalLong offset = findPartitionDataOffset(instanceFile, uuid);
-            if (!offset.isPresent()) continue;
+        OptionalLong offset = findPartitionDataOffset(instanceFile, partitionUuid);
+        assertThat(offset.isPresent()).isTrue();
 
-            flipBit(instanceFile, offset.getAsLong());
-            assertThat(tryBootVm("test_vm_integrity")).isFalse();
-            flipBit(instanceFile, offset.getAsLong());
-        }
+        flipBit(instanceFile, offset.getAsLong());
+        assertThat(tryBootVm("test_vm_integrity")).isFalse();
     }
+
+    @Test
+    public void bootFailsWhenMicrodroidDataIsCompromised()
+            throws VirtualMachineException, InterruptedException, IOException {
+        assume().withMessage("Skip on Cuttlefish. b/195765441")
+                .that(android.os.Build.DEVICE)
+                .isNotEqualTo("vsoc_x86_64");
+
+        tryCompromisingInstanceDiskPartition(MICRODROID_PARTITION_UUID);
+    }
+
+    /*
+    // TODO(b/218461230): uncomment these after u-boot update
+    @Test
+    public void bootFailsWhenUBootAvbDataIsCompromised()
+            throws VirtualMachineException, InterruptedException, IOException {
+        assume().withMessage("Skip on Cuttlefish. b/195765441")
+                .that(android.os.Build.DEVICE)
+                .isNotEqualTo("vsoc_x86_64");
+
+        assume().withMessage("Skip where protected VMs aren't support")
+                .that(mProtectedVm)
+                .isTrue();
+
+        tryCompromisingInstanceDiskPartition(U_BOOT_AVB_PARTITION_UUID);
+    }
+
+    @Test
+    public void bootFailsWhenUBootEnvDataIsCompromised()
+            throws VirtualMachineException, InterruptedException, IOException {
+        assume().withMessage("Skip on Cuttlefish. b/195765441")
+                .that(android.os.Build.DEVICE)
+                .isNotEqualTo("vsoc_x86_64");
+
+        assume().withMessage("Skip where protected VMs aren't support")
+                .that(mProtectedVm)
+                .isTrue();
+
+        tryCompromisingInstanceDiskPartition(U_BOOT_ENV_PARTITION_UUID);
+    }
+    */
 }