commit 6c60feaed5d8495340f1f10db772873c34e5e12d
author Jiyong Park <jiyong@google.com> Mon Oct 24 16:10:01 2022 +0900
committer Jiyong Park <jiyong@google.com> Mon Oct 24 22:52:19 2022 +0900
tree cd694b64140fb89010b56561681d679cdf71323b
parent bffe192bf7cb5846588a1b479e592a62eafb0690

Remove unnecessary logs

Some info-level logs are removed as they are not quite useful for
debugging. In addition, logs from the `disk` crate are suppressed to
reduce log spamming (they also are not useful for debugging) as below.

I crosvm  : disk size 115,
I crosvm  : Disk image file is hosted onf2f52010
I crosvm  : disk size 20480,
I crosvm  : Disk image file is hosted on file system type f2f52010

Bug: 251751405
Test: N/A
Change-Id: Ibae5681aee6880a8de38eede550ca8556392a24c

virtualizationservice/src/aidl.rs

diff --git a/virtualizationservice/src/aidl.rs b/virtualizationservice/src/aidl.rs
index 1eec765..6761f2d 100644
--- a/virtualizationservice/src/aidl.rs
+++ b/virtualizationservice/src/aidl.rs
@@ -253,7 +253,6 @@
 fn handle_stream_connection_tombstoned() -> Result<()> {
     let listener =
         VsockListener::bind_with_cid_port(VMADDR_CID_HOST, VM_TOMBSTONES_SERVICE_PORT as u32)?;
-    info!("Listening to tombstones from guests ...");
     for incoming_stream in listener.incoming() {
         let mut incoming_stream = match incoming_stream {
             Err(e) => {

virtualizationservice/src/crosvm.rs

diff --git a/virtualizationservice/src/crosvm.rs b/virtualizationservice/src/crosvm.rs
index 749970c..f3abee0 100644
--- a/virtualizationservice/src/crosvm.rs
+++ b/virtualizationservice/src/crosvm.rs
@@ -451,6 +451,10 @@
     // TODO(qwandor): Remove --disable-sandbox.
     command
         .arg("--extended-status")
+        // Configure the logger for the crosvm process to silence logs from the disk crate which
+        // don't provide much information to us (but do spamming us).
+        .arg("--log-level")
+        .arg("info,disk=off")
         .arg("run")
         .arg("--disable-sandbox")
         .arg("--no-balloon")

virtualizationservice/src/main.rs

diff --git a/virtualizationservice/src/main.rs b/virtualizationservice/src/main.rs
index 327a45d..828d3a2 100644
--- a/virtualizationservice/src/main.rs
+++ b/virtualizationservice/src/main.rs
@@ -22,6 +22,7 @@
 mod selinux;
 
 use crate::aidl::{VirtualizationService, BINDER_SERVICE_IDENTIFIER, TEMPORARY_DIRECTORY};
+use android_logger::{Config, FilterBuilder};
 use android_system_virtualizationservice::aidl::android::system::virtualizationservice::IVirtualizationService::BnVirtualizationService;
 use binder::{register_lazy_service, BinderFeatures, ProcessState};
 use anyhow::Error;
@@ -41,10 +42,15 @@
 
 fn main() {
     android_logger::init_once(
-        android_logger::Config::default()
+        Config::default()
             .with_tag(LOG_TAG)
             .with_min_level(Level::Info)
-            .with_log_id(android_logger::LogId::System),
+            .with_log_id(android_logger::LogId::System)
+            .with_filter(
+                // Reduce logspam by silencing logs from the disk crate which don't provide much
+                // information to us.
+                FilterBuilder::new().parse("info,disk=off").build(),
+            ),
     );
 
     clear_temporary_files().expect("Failed to delete old temporary files");