commit 52bfdd2fe3568871c90288456577fc8d52d1b90b
author Victor Hsieh <victorhsieh@google.com> Tue Oct 26 16:50:53 2021 -0700
committer Victor Hsieh <victorhsieh@google.com> Wed Oct 27 08:09:58 2021 -0700
tree c949be5bae415c0d81424456142122d32fbf4854
parent 0d6db2f482bd947dea3af53f0eed37ec4fc0ea87

Don't open directory with O_RDWR

Apparently, a directory cannot be opened with O_RDWR, otherwise open(2)
will return EISDIR. This is also documented in manpage.

Bug: 203251769
Test: no more EISDIR on open(2)
Change-Id: Ibe02bf793c1775475c086ec0122ec42dc902be16

authfs/tests/open_then_run.rs

diff --git a/authfs/tests/open_then_run.rs b/authfs/tests/open_then_run.rs
index ba3ed38..a540f9d 100644
--- a/authfs/tests/open_then_run.rs
+++ b/authfs/tests/open_then_run.rs
@@ -118,7 +118,7 @@
     })?;
 
     let dir_files = parse_and_create_file_mapping(matches.values_of("open-dir"), |path| {
-        Dir::open(path, OFlag::O_DIRECTORY | OFlag::O_RDWR, Mode::S_IRWXU)
+        Dir::open(path, OFlag::O_DIRECTORY | OFlag::O_RDONLY, Mode::S_IRWXU)
             .with_context(|| format!("Open {} directory", path))
     })?;