commit 9646db93d45817d7a54fffe1072af2fc78f270b1
author Alan Stokes <alanstokes@google.com> Tue Dec 14 13:22:33 2021 +0000
committer Alan Stokes <alanstokes@google.com> Wed Dec 15 09:42:55 2021 +0000
tree 8f7adf2807f69e17cf945644b1e24d12411a0fb6
parent ac9aa1a06bbaf8179701d2ef86c74809fbb33bc0

Don't write artifacts under staging

The staging dir (.../com.android.art/staging) is where odrefresh
creates artifacts before moving (well, copying) them to the final
target directory, typically .../com.android.art/dalvik-cache, or
compos-pending in our case).

But we were creating directories .../com.android.art/staging/staging
and .../com.android.art/staging/dalvik-cache instead.

So we need to pass the staging dir and the output dir separately, and
also specify the sub-directory name under the output directory where
the final artifacts should end up.

While I'm modifying the signature of odrefresh() I also made it return
just the odrefresh exit code.

Modified the implementation and callers to handle the new signature.

Also made a couple of small fixes.

Bug: 209572296
Bug: 210460516
Test: composd_cmd forced-odrefresh
Test: composd_cmd async-odrefresh
Test: (both with selinux in microdroid disabled)
Change-Id: I3dcdab7d9ae042e46f73d716f81f834de0f4c4f0