commit 23cff7159e87c73d4b46b6db1f5fc81d67f41eba
author David Dai <davidai@google.com> Thu Jun 13 19:23:45 2024 +0000
committer David Dai <davidai@google.com> Thu Jun 13 23:21:01 2024 +0000
tree 86f2b07a47c1b104e6e0407b6338d16c8bda46d7
parent 4ec136b3f76fa8dc5ca7e2ad948c6826c1651eef

virtmgr: Add boost_uclamp

To ensure consistent results during testing, passes the boost_uclamp
as a hint to the host scheduler to reduce variance and set
a mininum floor for performance.

Also enable boost_uclamp for Microdroid Boot tests,
partially authored by ioffe.

Bug: 342349882
Test: Booted a VM and checked uClamp
Change-Id: I0d40163515d1a4e41bde6cc81916de51f798813c
Signed-off-by: David Dai <davidai@google.com>

virtualizationmanager/src/aidl.rs

diff --git a/virtualizationmanager/src/aidl.rs b/virtualizationmanager/src/aidl.rs
index bb21102..8e1b6bb 100644
--- a/virtualizationmanager/src/aidl.rs
+++ b/virtualizationmanager/src/aidl.rs
@@ -599,6 +599,7 @@
             tap,
             virtio_snd_backend,
             console_input_device: config.consoleInputDevice.clone(),
+            boost_uclamp: config.boostUclamp,
         };
         let instance = Arc::new(
             VmInstance::new(
@@ -960,6 +961,7 @@
     vm_config.protectedVm = config.protectedVm;
     vm_config.cpuTopology = config.cpuTopology;
     vm_config.hugePages = config.hugePages || vm_payload_config.hugepages;
+    vm_config.boostUclamp = config.boostUclamp;
 
     // Microdroid takes additional init ramdisk & (optionally) storage image
     add_microdroid_system_images(config, instance_file, storage_image, os_name, &mut vm_config)?;

virtualizationmanager/src/crosvm.rs

diff --git a/virtualizationmanager/src/crosvm.rs b/virtualizationmanager/src/crosvm.rs
index 4b03bac..79c7b7f 100644
--- a/virtualizationmanager/src/crosvm.rs
+++ b/virtualizationmanager/src/crosvm.rs
@@ -132,6 +132,7 @@
     pub tap: Option<File>,
     pub virtio_snd_backend: Option<String>,
     pub console_input_device: Option<String>,
+    pub boost_uclamp: bool,
 }
 
 #[derive(Debug)]
@@ -1054,6 +1055,10 @@
         command.arg("--hugepages");
     }
 
+    if config.boost_uclamp {
+        command.arg("--boost-uclamp");
+    }
+
     append_platform_devices(&mut command, &mut preserved_fds, &config)?;
 
     debug!("Preserving FDs {:?}", preserved_fds);