| commit | df664988fe2a020b293c5fd1bb961041fc2459f2 | [log] [tgz] |
|---|---|---|
| author | Pierre-Clément Tosi <ptosi@google.com> | Wed Oct 19 16:50:35 2022 +0100 |
| committer | Pierre-Clément Tosi <ptosi@google.com> | Tue Oct 25 12:23:28 2022 +0000 |
| tree | fe92d6fe5dbc1f31c2d05903fbe3ff47c2e5d331 | |
| parent | f9c6a9b6914e15252939c3ad4e6b10ca406a8b52 [diff] |
pvmfw: Hack MMIO_GUARD_MAP to expect i32
Until aosp/2254520, pKVM returned a signed 32-bit integer instead of the
SMCCC-compliant i64 so parse results that could be negative i32 values
as their sign-extended i64 counterparts. The fact that this masks the
range 0x8000_0000-0xFFFF_FFFF, which should otherwise be interpreted as
positive u64 values, should not be an issue as the only non-negative
value that should be expected from MMIO_GUARD_MAP is zero ("SUCCESS").
Log the workaround, to help with debugging.
Note: this commit is intended to be reverted once the bug is fixed.
Bug: 253586500
Test: crosvm run --protected-vm-without-firmware <pvmfw.bin>
Test: # Issue MMIO_GUARD_MAP without first MMIO_GUARD_ENROLL-ing
Change-Id: I974e9783f114fb2d821b3806fdb69fb6c8eefdc7
This repository contains userspace services related to running virtual machines on Android, especially protected virtual machines. See the getting started documentation and Microdroid README for more information.