commit 04e5dbdfeeff55742c22729b36a2a256420e0482
author Dan Albert <danalbert@google.com> Mon May 08 22:49:40 2023 +0000
committer Andrew Walbran <qwandor@google.com> Wed May 10 08:59:37 2023 +0000
tree de22148e16da9c8392595d211693293b09767b7d
parent 08bf786f22090d764ba49b11b713714b280e57c7

Bind ignored results.

std::io::Error implements Drop in some configurations. A value that
implements Drop will be dropped immediately when not bound (and _ does
not bind). This is asymptomatic in this case but we want to deny this
behavior globally because it has very surprising behavior when the
"unused" value is a lock.

Bug: 281730184
Test: mm
Change-Id: I325f7bb1ca8eb74f56fbb3926e4e79e833a265a4

libs/devicemapper/src/lib.rs

diff --git a/libs/devicemapper/src/lib.rs b/libs/devicemapper/src/lib.rs
index fec0114..a0435e4 100644
--- a/libs/devicemapper/src/lib.rs
+++ b/libs/devicemapper/src/lib.rs
@@ -338,8 +338,8 @@
 
         scopeguard::defer! {
             loopdevice::detach(&data_device).unwrap();
-            _ = delete_device(&dm, device);
-            _ = delete_device(&dm, &device_diff);
+            let _ignored1 = delete_device(&dm, device);
+            let _ignored2 = delete_device(&dm, &device_diff);
         }
 
         let target = DmCryptTargetBuilder::default()
@@ -380,8 +380,8 @@
         let device_diff = device.to_owned() + "_diff";
         scopeguard::defer! {
             loopdevice::detach(&data_device).unwrap();
-            _ = delete_device(&dm, device);
-            _ = delete_device(&dm, &device_diff);
+            let _ignored1 = delete_device(&dm, device);
+            let _ignored2 = delete_device(&dm, &device_diff);
         }
 
         let target = DmCryptTargetBuilder::default()