commit f037e7729688b574e713ef06108781adb349a35b
author Maciej Żenczykowski <maze@google.com> Sun Nov 10 23:02:13 2019 -0800
committer Maciej Żenczykowski <maze@google.com> Sun Nov 10 23:48:37 2019 -0800
tree d43b25913711f8c8a22da89d44fc88459ec70638
parent a02523b26245ce3f39cf584ec5f8562f053b6d5c

make clat checksum tests more reliable

This is to allow increasing pseudochecksum returned by 0xFFFF,
which is another form of 16-bit 1's complement 0 and thus irrelevant.

Test: builds, atest
Signed-off-by: Maciej Żenczykowski <maze@google.com>
Change-Id: I8cfa04ed1c0bdde2a605cff258a12690748f3bd5

clatd_test.cpp

diff --git a/clatd_test.cpp b/clatd_test.cpp
index 8e49824..9709890 100644
--- a/clatd_test.cpp
+++ b/clatd_test.cpp
@@ -903,8 +903,10 @@
   uint32_t ipv6_pseudo_sum =
     ipv6_pseudo_header_checksum((struct ip6_hdr *)ip6, UDP_LEN, IPPROTO_UDP);
 
-  EXPECT_EQ(0x3ad0U, ipv4_pseudo_sum) << "IPv4 pseudo-checksum sanity check\n";
-  EXPECT_EQ(0x2644bU, ipv6_pseudo_sum) << "IPv6 pseudo-checksum sanity check\n";
+  EXPECT_NE(0, ipv4_pseudo_sum);
+  EXPECT_NE(0, ipv6_pseudo_sum);
+  EXPECT_EQ(0x3ad0U, ipv4_pseudo_sum % 0xFFFF) << "IPv4 pseudo-checksum sanity check\n";
+  EXPECT_EQ(0x644dU, ipv6_pseudo_sum % 0xFFFF) << "IPv6 pseudo-checksum sanity check\n";
   EXPECT_EQ(
       kUdpV4Checksum,
       ip_checksum_finish(ipv4_pseudo_sum + kUdpPartialChecksum + kPayloadPartialChecksum))