commit e8dceddeec89515ee0ea53e6ad3d92bb5d63d623
author Maciej Żenczykowski <maze@google.com> Thu Jun 09 23:27:32 2022 +0000
committer Maciej Żenczykowski <maze@google.com> Fri Jun 10 21:10:15 2022 +0000
tree ec04dacc7e6fc5820e04b73aaecbb5d9d3d787fb
parent 0b2781b5ecd863d417adc04c60023c48e2cc55ad

enable NETLINK_EXT_ACK extended error reporting

(we don't yet do anything with it, but at least in strace we should
now see more detailed errors from the kernel)

Test: TreeHugger
Signed-off-by: Maciej Żenczykowski <maze@google.com>
Change-Id: I6a34a0e7e866bbde41daef23870ad90dceee6ded

staticlibs/native/tcutils/tcutils.cpp

diff --git a/staticlibs/native/tcutils/tcutils.cpp b/staticlibs/native/tcutils/tcutils.cpp
index 144a4c9..4101885 100644
--- a/staticlibs/native/tcutils/tcutils.cpp
+++ b/staticlibs/native/tcutils/tcutils.cpp
@@ -386,6 +386,12 @@
     return -error;
   }
 
+  if (setsockopt(fd, SOL_NETLINK, NETLINK_EXT_ACK, &on, sizeof(on))) {
+    int error = errno;
+    ALOGW("setsockopt(fd, SOL_NETLINK, NETLINK_EXT_ACK, 1): %d", error);
+    // will fail on 4.9 kernels so don't: return -error;
+  }
+
   // this is needed to get valid strace netlink parsing, it allocates the pid
   if (bind(fd, (const struct sockaddr *)&KERNEL_NLADDR,
            sizeof(KERNEL_NLADDR))) {