commit bf4f1d9e98c5acf864bb7f7883c114edf1ab9745
author Cody Kesting <ckesting@google.com> Tue Mar 31 20:18:01 2020 +0000
committer Gerrit Code Review <noreply-gerritcodereview@google.com> Tue Mar 31 20:18:01 2020 +0000
tree af751820b4751b3b13369e9dec28541fb6c8d962
parent 87ce14f328dd6292706dfe32fc12796333dd07f6
parent 2b1a61cf4bc1f8d4d103928e18b81f5105d3f445

Merge "Simplify unregister logic for Connectivity Diagnostics callbacks."

services/core/java/com/android/server/ConnectivityService.java

diff --git a/services/core/java/com/android/server/ConnectivityService.java b/services/core/java/com/android/server/ConnectivityService.java
index 4d03f66..96197ce 100644
--- a/services/core/java/com/android/server/ConnectivityService.java
+++ b/services/core/java/com/android/server/ConnectivityService.java
@@ -7883,12 +7883,14 @@
         ensureRunningOnConnectivityServiceThread();
         final IBinder iCb = cb.asBinder();
 
-        if (!mConnectivityDiagnosticsCallbacks.containsKey(iCb)) {
+        final ConnectivityDiagnosticsCallbackInfo cbInfo =
+                mConnectivityDiagnosticsCallbacks.remove(iCb);
+        if (cbInfo == null) {
             if (VDBG) log("Removing diagnostics callback that is not currently registered");
             return;
         }
 
-        final NetworkRequestInfo nri = mConnectivityDiagnosticsCallbacks.get(iCb).mRequestInfo;
+        final NetworkRequestInfo nri = cbInfo.mRequestInfo;
 
         if (uid != nri.mUid) {
             if (VDBG) loge("Different uid than registrant attempting to unregister cb");
@@ -7900,8 +7902,6 @@
         // enforceRequestCountLimit().
         decrementNetworkRequestPerUidCount(nri);
 
-        final ConnectivityDiagnosticsCallbackInfo cbInfo =
-                mConnectivityDiagnosticsCallbacks.remove(iCb);
         iCb.unlinkToDeath(cbInfo, 0);
     }