commit | b375738a52cb316e8ed283ece6aa8f877fe6b2f2 | [log] [tgz] |
---|---|---|
author | paulhu <paulhu@google.com> | Thu Apr 04 00:57:26 2019 -0700 |
committer | Lorenzo Colitti <lorenzo@google.com> | Tue Apr 09 08:57:08 2019 +0000 |
tree | e7d29962912d5c5671fc2aad2903542bc5d14d81 | |
parent | 7a9206fcdcdc9130488c5d638f186b63170fb391 [diff] |
Fix ConnectivityServiceTest fail. NetdService#getInstance() will get null object in WrappedConnectivityService constructor. Then pass this null INetd object to PermissionMonitor will case NPE in PermissionMonitor#sendPackagePermissionsToNetd() Bug: 128024100 Test: atest FrameworksNetTests Change-Id: Ia1c80f9600a19c4aaf3f3c1b497b355d96c49c8e Merged-In: I7f185e731db91c30a9b0f14aefbdbb067942190e Merged-In: Ic77ef73841266da487401ffd657ef63562b6fc1e (cherry picked from commit 7d215078521ea03bbd692364e882d02ad065ced0)
diff --git a/services/core/java/com/android/server/connectivity/PermissionMonitor.java b/services/core/java/com/android/server/connectivity/PermissionMonitor.java index da1360d..b694602 100644 --- a/services/core/java/com/android/server/connectivity/PermissionMonitor.java +++ b/services/core/java/com/android/server/connectivity/PermissionMonitor.java
@@ -469,7 +469,10 @@ */ @VisibleForTesting void sendPackagePermissionsToNetd(SparseIntArray netdPermissionsAppIds) { - + if (mNetd == null) { + Log.e(TAG, "Failed to get the netd service"); + return; + } ArrayList<Integer> allPermissionAppIds = new ArrayList<>(); ArrayList<Integer> internetPermissionAppIds = new ArrayList<>(); ArrayList<Integer> updateStatsPermissionAppIds = new ArrayList<>();