commit a7c7f764fe7b1685483db610444be95fb6309247
author Lorenzo Colitti <lorenzo@google.com> Wed Feb 09 16:29:29 2022 +0000
committer Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com> Wed Feb 09 16:29:29 2022 +0000
tree abbcc15abef7f54a3e2c1b9d8d4ea2dd0219707e
parent bdb066a27b6ab0d9b935ec0c3c16aad0f9a0c588
parent 5216fc9eefded0b7033073f2630ee5178dec8d35

Fix testIpClientIsNotStartedWhenLinkIsDown. am: 5216fc9eef

Original change: https://android-review.googlesource.com/c/platform/frameworks/opt/net/ethernet/+/1976968

Change-Id: I78ad7e8eb718ffceae8990c7ea7c9298ecd1617e

tests/ethernet/java/com/android/server/ethernet/EthernetNetworkFactoryTest.java

diff --git a/tests/ethernet/java/com/android/server/ethernet/EthernetNetworkFactoryTest.java b/tests/ethernet/java/com/android/server/ethernet/EthernetNetworkFactoryTest.java
index 6e7c267..e10497e 100644
--- a/tests/ethernet/java/com/android/server/ethernet/EthernetNetworkFactoryTest.java
+++ b/tests/ethernet/java/com/android/server/ethernet/EthernetNetworkFactoryTest.java
@@ -456,9 +456,10 @@
                 .build();
         mNetFactory.needNetworkFor(specificNetRequest);
 
-        // TODO(b/155707957): BUG: IPClient should not be started when the interface link state
-        //  is down.
-        verify(mDeps).makeIpClient(any(), any(), any());
+        verify(mDeps, never()).makeIpClient(any(), any(), any());
+
+        mNetFactory.updateInterfaceLinkState(TEST_IFACE, true, NULL_LISTENER);
+        verify(mDeps).makeIpClient(any(), eq(TEST_IFACE), any());
     }
 
     @Test