gn2bp: change filegroup to cc_defaults
Filegroups do not support per-target/arch sources, but cc_defaults do.
Since modules that are not compiled (filegroups, genrules, cc_defaults)
do not support deps, only cc_library or cc_binary targets can depend on
filegroups. This means, it should be safe to convert filegroups to
cc_defaults.
Test: //components/cronet/android:cronet
Change-Id: Ie937102c093d46d42867e0472e43901fdf427894
diff --git a/tools/gn2bp/gen_android_bp b/tools/gn2bp/gen_android_bp
index 4e33a7a..24d5584 100755
--- a/tools/gn2bp/gen_android_bp
+++ b/tools/gn2bp/gen_android_bp
@@ -993,7 +993,7 @@
elif target.type == 'shared_library':
module = Module('cc_library_shared', bp_module_name, gn_target_name)
elif target.type == 'source_set':
- module = Module('filegroup', bp_module_name, gn_target_name)
+ module = Module('cc_defaults', bp_module_name, gn_target_name)
elif target.type == 'group':
# "group" targets are resolved recursively by gn_utils.get_target().
# There's nothing we need to do at this level for them.
@@ -1137,8 +1137,8 @@
module.shared_libs.add(dep_module.name)
elif dep_module.type == 'cc_library_static':
module.static_libs.add(dep_module.name)
- elif dep_module.type == 'filegroup':
- module.srcs.add(':' + dep_module.name)
+ elif dep_module.type == 'cc_defaults':
+ module.defaults.append(dep_module.name)
elif dep_module.type == 'genrule':
module.generated_headers.update(dep_module.genrule_headers)
module.srcs.update(dep_module.genrule_srcs)