commit 7d898403a92ea6b1464a3f459ece1ce323e30d82
author Frank Li <lifr@google.com> Wed Mar 16 12:28:24 2022 +0000
committer Gerrit Code Review <noreply-gerritcodereview@google.com> Wed Mar 16 12:28:24 2022 +0000
tree 7328a97b38d71df2d23e17d01c4f1b4cd35fb925
parent ed5add94e95d145254ec9dc5a071f7e4a219850a
parent 4e70104466f88b0fb0632f4b58f34be6dd116ad7

Merge "[DU04-3]Appropriate changes to the NetworkPolicyManager API"

staticlibs/testutils/devicetests/com/android/testutils/NetworkStatsProviderCbStubCompat.java

diff --git a/staticlibs/testutils/devicetests/com/android/testutils/NetworkStatsProviderCbStubCompat.java b/staticlibs/testutils/devicetests/com/android/testutils/NetworkStatsProviderCbStubCompat.java
index e84a224..642da7a 100644
--- a/staticlibs/testutils/devicetests/com/android/testutils/NetworkStatsProviderCbStubCompat.java
+++ b/staticlibs/testutils/devicetests/com/android/testutils/NetworkStatsProviderCbStubCompat.java
@@ -32,10 +32,13 @@
     @Override
     public void notifyAlertReached() throws RemoteException {}
 
-    // Removed in S.
+    /** Added in T. */
     public void notifyLimitReached() throws RemoteException {}
 
-    // Added in S.
+    /** Added in T. */
+    public void notifyWarningReached() throws RemoteException {}
+
+    /** Added in S, removed in T. */
     public void notifyWarningOrLimitReached() throws RemoteException {}
 
     @Override

staticlibs/testutils/devicetests/com/android/testutils/TestableNetworkStatsProviderCbBinder.kt

diff --git a/staticlibs/testutils/devicetests/com/android/testutils/TestableNetworkStatsProviderCbBinder.kt b/staticlibs/testutils/devicetests/com/android/testutils/TestableNetworkStatsProviderCbBinder.kt
index c039cad..5547c90 100644
--- a/staticlibs/testutils/devicetests/com/android/testutils/TestableNetworkStatsProviderCbBinder.kt
+++ b/staticlibs/testutils/devicetests/com/android/testutils/TestableNetworkStatsProviderCbBinder.kt
@@ -31,8 +31,9 @@
             val ifaceStats: NetworkStats,
             val uidStats: NetworkStats
         ) : CallbackType()
+        object NotifyWarningReached : CallbackType()
+        object NotifyLimitReached : CallbackType()
         object NotifyWarningOrLimitReached : CallbackType()
-        object LegacyNotifyLimitReached : CallbackType()
         object NotifyAlertReached : CallbackType()
         object Unregister : CallbackType()
     }
@@ -43,13 +44,17 @@
         history.add(CallbackType.NotifyStatsUpdated(token, ifaceStats, uidStats))
     }
 
-    override fun notifyWarningOrLimitReached() {
-        history.add(CallbackType.NotifyWarningOrLimitReached)
+    override fun notifyWarningReached() {
+        history.add(CallbackType.NotifyWarningReached)
     }
 
     override fun notifyLimitReached() {
-        // Older callback renamed to notifyWarningOrLimitReached in S
-        history.add(CallbackType.LegacyNotifyLimitReached)
+        history.add(CallbackType.NotifyLimitReached)
+    }
+
+    override fun notifyWarningOrLimitReached() {
+        // Older callback is split into notifyLimitReached and notifyWarningReached in T.
+        history.add(CallbackType.NotifyWarningOrLimitReached)
     }
 
     override fun notifyAlertReached() {
@@ -75,12 +80,15 @@
         assertNetworkStatsEquals(uidStats, event.uidStats)
     }
 
+    fun expectNotifyWarningReached() =
+            assertEquals(CallbackType.NotifyWarningReached, history.poll(DEFAULT_TIMEOUT_MS))
+
+    fun expectNotifyLimitReached() =
+            assertEquals(CallbackType.NotifyLimitReached, history.poll(DEFAULT_TIMEOUT_MS))
+
     fun expectNotifyWarningOrLimitReached() =
             assertEquals(CallbackType.NotifyWarningOrLimitReached, history.poll(DEFAULT_TIMEOUT_MS))
 
-    fun expectLegacyNotifyLimitReached() =
-            assertEquals(CallbackType.LegacyNotifyLimitReached, history.poll(DEFAULT_TIMEOUT_MS))
-
     fun expectNotifyAlertReached() =
             assertEquals(CallbackType.NotifyAlertReached, history.poll(DEFAULT_TIMEOUT_MS))