Enable strict_updatability_linting in frameworks/libs/net
Enable the strict_updatability_linting here first as a prior
commit to enable strict_updatability_linting in connectivity
modules.
Bug: 188851968
Test: m lint-check ; atest NetworkStaticLibTests
Change-Id: Idac98a1c85bf5bb86269b1daad2b444cfb58db8a
diff --git a/staticlibs/Android.bp b/staticlibs/Android.bp
index a9689f1..c6d64e4 100644
--- a/staticlibs/Android.bp
+++ b/staticlibs/Android.bp
@@ -70,6 +70,7 @@
"androidx.annotation_annotation",
"framework-annotations-lib",
],
+ lint: { strict_updatability_linting: true },
}
java_defaults {
@@ -118,6 +119,7 @@
"com.android.tethering",
"//apex_available:platform",
],
+ lint: { strict_updatability_linting: true },
}
java_library {
@@ -145,6 +147,7 @@
"com.android.tethering",
"//apex_available:platform",
],
+ lint: { strict_updatability_linting: true },
}
java_library {
@@ -169,6 +172,7 @@
"com.android.tethering",
"//apex_available:platform",
],
+ lint: { strict_updatability_linting: true },
}
java_library {
@@ -199,6 +203,7 @@
"com.android.tethering",
"//apex_available:platform",
],
+ lint: { strict_updatability_linting: true },
}
java_library {
@@ -229,6 +234,7 @@
"//frameworks/libs/net/common/device",
"//packages/modules/Wifi/framework/tests:__subpackages__",
],
+ lint: { strict_updatability_linting: true },
}
filegroup {
name: "net-utils-services-common-srcs",
@@ -260,6 +266,7 @@
visibility: [
"//frameworks/base/services/net",
],
+ lint: { strict_updatability_linting: true },
}
// Use a filegroup and not a library for telephony sources, as framework-annotations cannot be
@@ -339,4 +346,5 @@
"//apex_available:anyapex",
"//apex_available:platform",
],
+ lint: { strict_updatability_linting: true },
}
diff --git a/staticlibs/tests/unit/Android.bp b/staticlibs/tests/unit/Android.bp
index 07a8200..21e8c64 100644
--- a/staticlibs/tests/unit/Android.bp
+++ b/staticlibs/tests/unit/Android.bp
@@ -30,7 +30,8 @@
"//packages/modules/Connectivity/tests:__subpackages__",
"//packages/modules/Connectivity/Tethering/tests:__subpackages__",
"//packages/modules/NetworkStack/tests/integration",
- ]
+ ],
+ lint: { strict_updatability_linting: true },
}
android_test {
@@ -46,4 +47,5 @@
],
jarjar_rules: "jarjar-rules.txt",
test_suites: ["device-tests"],
+ lint: { strict_updatability_linting: true },
}
diff --git a/staticlibs/tests/unit/lint-baseline.xml b/staticlibs/tests/unit/lint-baseline.xml
deleted file mode 100644
index e3a6c1e..0000000
--- a/staticlibs/tests/unit/lint-baseline.xml
+++ /dev/null
@@ -1,48 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
-<issues format="5" by="lint 4.1.0" client="cli" variant="all" version="4.1.0">
-
- <issue
- id="NewApi"
- message="Call requires API level R (current min is 29): `android.app.AppOpsManager#noteOp`"
- errorLine1=" when(mMockAppOps.noteOp(AppOpsManager.OPSTR_WIFI_SCAN, mUid, TEST_PKG_NAME,"
- errorLine2=" ~~~~~~">
- <location
- file="frameworks/libs/net/common/tests/unit/src/com/android/net/module/util/LocationPermissionCheckerTest.java"
- line="109"
- column="26"/>
- </issue>
-
- <issue
- id="NewApi"
- message="Call requires API level R (current min is 29): `android.app.AppOpsManager#noteOp`"
- errorLine1=" when(mMockAppOps.noteOp(eq(AppOpsManager.OPSTR_COARSE_LOCATION), eq(mUid),"
- errorLine2=" ~~~~~~">
- <location
- file="frameworks/libs/net/common/tests/unit/src/com/android/net/module/util/LocationPermissionCheckerTest.java"
- line="111"
- column="26"/>
- </issue>
-
- <issue
- id="NewApi"
- message="Call requires API level R (current min is 29): `android.app.AppOpsManager#noteOp`"
- errorLine1=" when(mMockAppOps.noteOp(eq(AppOpsManager.OPSTR_FINE_LOCATION), eq(mUid),"
- errorLine2=" ~~~~~~">
- <location
- file="frameworks/libs/net/common/tests/unit/src/com/android/net/module/util/LocationPermissionCheckerTest.java"
- line="114"
- column="26"/>
- </issue>
-
- <issue
- id="NewApi"
- message="Call requires API level R (current min is 29): `android.net.NetworkCapabilities()`"
- errorLine1=" val nc = NetworkCapabilities()"
- errorLine2=" ~~~~~~~~~~~~~~~~~~~~~">
- <location
- file="frameworks/libs/net/common/tests/unit/src/com/android/net/module/util/NetworkCapabilitiesUtilsTest.kt"
- line="93"
- column="18"/>
- </issue>
-
-</issues>
diff --git a/staticlibs/tests/unit/src/com/android/net/module/util/LocationPermissionCheckerTest.java b/staticlibs/tests/unit/src/com/android/net/module/util/LocationPermissionCheckerTest.java
index 3fb1e92..84018a5 100644
--- a/staticlibs/tests/unit/src/com/android/net/module/util/LocationPermissionCheckerTest.java
+++ b/staticlibs/tests/unit/src/com/android/net/module/util/LocationPermissionCheckerTest.java
@@ -42,6 +42,8 @@
import android.os.UserHandle;
import android.os.UserManager;
+import androidx.annotation.RequiresApi;
+
import com.android.testutils.DevSdkIgnoreRule;
import org.junit.Assert;
@@ -56,6 +58,7 @@
import java.util.HashMap;
/** Unit tests for {@link LocationPermissionChecker}. */
+@RequiresApi(Build.VERSION_CODES.R)
public class LocationPermissionCheckerTest {
@Rule
public final DevSdkIgnoreRule mIgnoreRule = new DevSdkIgnoreRule(
diff --git a/staticlibs/tests/unit/src/com/android/net/module/util/NetworkCapabilitiesUtilsTest.kt b/staticlibs/tests/unit/src/com/android/net/module/util/NetworkCapabilitiesUtilsTest.kt
index 5f15c6a..f78c74e 100644
--- a/staticlibs/tests/unit/src/com/android/net/module/util/NetworkCapabilitiesUtilsTest.kt
+++ b/staticlibs/tests/unit/src/com/android/net/module/util/NetworkCapabilitiesUtilsTest.kt
@@ -16,6 +16,7 @@
package com.android.net.module.util
+import android.annotation.TargetApi
import android.net.NetworkCapabilities
import android.net.NetworkCapabilities.NET_CAPABILITY_CBS
import android.net.NetworkCapabilities.NET_CAPABILITY_EIMS
@@ -29,6 +30,7 @@
import android.net.NetworkCapabilities.TRANSPORT_VPN
import android.net.NetworkCapabilities.TRANSPORT_WIFI
import android.net.NetworkCapabilities.TRANSPORT_WIFI_AWARE
+import android.os.Build
import androidx.test.filters.SmallTest
import androidx.test.runner.AndroidJUnit4
import com.android.net.module.util.NetworkCapabilitiesUtils.RESTRICTED_CAPABILITIES
@@ -88,7 +90,9 @@
assertTrue(bits contentEquals unpackBits(packedBits))
}
- @Test
+ // NetworkCapabilities constructor and Builder are not available until R. Mark TargetApi to
+ // ignore the linter error since it's used in only unit test.
+ @Test @TargetApi(Build.VERSION_CODES.R)
fun testInferRestrictedCapability() {
val nc = NetworkCapabilities()
// Default capabilities don't have restricted capability.
diff --git a/staticlibs/testutils/Android.bp b/staticlibs/testutils/Android.bp
index 9fd30f7..2f0bcc3 100644
--- a/staticlibs/testutils/Android.bp
+++ b/staticlibs/testutils/Android.bp
@@ -38,6 +38,7 @@
"net-utils-device-common-netlink",
"modules-utils-build_system",
],
+ lint: { strict_updatability_linting: true },
}
java_library {
@@ -59,7 +60,8 @@
],
static_libs: [
"kotlin-test"
- ]
+ ],
+ lint: { strict_updatability_linting: true },
}
java_test_host {
diff --git a/staticlibs/testutils/app/connectivitychecker/Android.bp b/staticlibs/testutils/app/connectivitychecker/Android.bp
index 79a4343..58f22db 100644
--- a/staticlibs/testutils/app/connectivitychecker/Android.bp
+++ b/staticlibs/testutils/app/connectivitychecker/Android.bp
@@ -30,4 +30,5 @@
"net-tests-utils",
],
host_required: ["net-tests-utils-host-common"],
+ lint: { strict_updatability_linting: true },
}