commit 3f5018f969f977c98b012cb28be6acc42d7d7de4
author Azhara Assanova <azharaa@google.com> Mon Dec 12 17:00:26 2022 +0000
committer Azhara Assanova <azharaa@google.com> Fri Jan 06 11:40:26 2023 +0000
tree 3bb7a334acd4513c74dfaa6e2e43683ef7e1bbd7
parent fc8464d500dbd4fbd55e7a81765fbd01bac90270

Make mutable implicit PendingIntent explicit for security reasons

Bug: 236704164
Bug: 229362273
Test: TH passes
Test: atest CtsNetTestCases
Change-Id: If5ea666da63628c0abd6f320420c10dd46498313

tests/cts/net/src/android/net/cts/ConnectivityManagerTest.java

diff --git a/tests/cts/net/src/android/net/cts/ConnectivityManagerTest.java b/tests/cts/net/src/android/net/cts/ConnectivityManagerTest.java
index 6c6070e..ef36e00 100644
--- a/tests/cts/net/src/android/net/cts/ConnectivityManagerTest.java
+++ b/tests/cts/net/src/android/net/cts/ConnectivityManagerTest.java
@@ -1187,7 +1187,8 @@
             final String extraBoolKey = "extra_bool";
             firstIntent = PendingIntent.getBroadcast(mContext,
                     0 /* requestCode */,
-                    new Intent(broadcastAction).putExtra(extraBoolKey, false),
+                    new Intent(broadcastAction).putExtra(extraBoolKey, false)
+                            .setPackage(mContext.getPackageName()),
                     PendingIntent.FLAG_UPDATE_CURRENT | pendingIntentFlagMutable);
 
             if (useListen) {
@@ -1200,7 +1201,8 @@
             // intent will be updated with the new extras
             secondIntent = PendingIntent.getBroadcast(mContext,
                     0 /* requestCode */,
-                    new Intent(broadcastAction).putExtra(extraBoolKey, true),
+                    new Intent(broadcastAction).putExtra(extraBoolKey, true)
+                            .setPackage(mContext.getPackageName()),
                     PendingIntent.FLAG_UPDATE_CURRENT | pendingIntentFlagMutable);
 
             // Because secondIntent.intentFilterEquals the first, the request should be replaced