commit 382ea38fc0f6aa4ee3380acdee714ad4cf0fae66
author Jonathan Basseri <misterikkit@google.com> Mon Oct 30 14:56:56 2017 -0700
committer Jonathan Basseri <misterikkit@google.com> Tue Oct 31 09:43:26 2017 -0700
tree 31ee8aeb9868603aeda936c34ade3cf8d15d1891
parent fb02e147728bc54aa7b2c09ed2b127e6f76cf341

Use random available port in CTS tests.

Let the OS pick a random unused port so that the test never gets
EADDRINUSE.

Bug: 68657805
Test: Run tests in android.net.cts.IpSecManagerTest
Change-Id: I7f6c68f3c92f5cbed856eda52adcdffb8adc4734

tests/cts/net/src/android/net/cts/IpSecManagerTest.java

diff --git a/tests/cts/net/src/android/net/cts/IpSecManagerTest.java b/tests/cts/net/src/android/net/cts/IpSecManagerTest.java
index 599102c..6348d04 100644
--- a/tests/cts/net/src/android/net/cts/IpSecManagerTest.java
+++ b/tests/cts/net/src/android/net/cts/IpSecManagerTest.java
@@ -155,8 +155,9 @@
                                         CRYPT_KEY.length * 8))
                         .buildTransportModeTransform(local);
 
-        // Hack to ensure the socket doesn't block indefinitely on failure
-        DatagramSocket localSocket = new DatagramSocket(8888);
+        // Bind localSocket to a random available port.
+        DatagramSocket localSocket = new DatagramSocket(0);
+        int localPort = localSocket.getLocalPort();
         localSocket.setSoTimeout(500);
         ParcelFileDescriptor pin = ParcelFileDescriptor.fromDatagramSocket(localSocket);
         FileDescriptor udpSocket = pin.getFileDescriptor();
@@ -165,7 +166,7 @@
         byte[] data = new String("Best test data ever!").getBytes("UTF-8");
 
         byte[] in = new byte[data.length];
-        Os.sendto(udpSocket, data, 0, data.length, 0, local, 8888);
+        Os.sendto(udpSocket, data, 0, data.length, 0, local, localPort);
         Os.read(udpSocket, in, 0, in.length);
         assertTrue("Encapsulated data did not match.", Arrays.equals(data, in));
         mISM.removeTransportModeTransform(udpSocket, transform);