bpf_existence_test - add U support
The logic about testing API levels was wrong: it simply isn't
meaningful to say it doesn't support and needs to be updated for U+.
This test *always* needs to be kept up to date wrt. any changes
we make to mainline provided bpf programs and maps.
That's why the test is in the same git repo and is MTS not CTS.
Additionally we *can* make (and have made) changes to programs/maps
available on older API levels as well, so it's not even set in stone
for older API levels either.
Getting rid of the api level checks simplifies things.
As does moving the 4.9+ check into the test logic itself.
This has the added benefit of not skipping the test on S
simply because kernel is < 4.9 [not that's valid, but...].
Test: TreeHugger
Signed-off-by: Maciej Żenczykowski <maze@google.com>
Change-Id: Ib0400f4534254b7a35a96d364720a7c800953456
diff --git a/tests/mts/bpf_existence_test.cpp b/tests/mts/bpf_existence_test.cpp
index aa5654a..c294e7b 100644
--- a/tests/mts/bpf_existence_test.cpp
+++ b/tests/mts/bpf_existence_test.cpp
@@ -20,8 +20,6 @@
#include <set>
#include <string>
-#include <android/api-level.h>
-#include <android-base/properties.h>
#include <android-modules-utils/sdk_level.h>
#include <bpf/BpfUtils.h>
@@ -45,7 +43,7 @@
class BpfExistenceTest : public ::testing::Test {
};
-// Part of Android R platform, but mainlined in S
+// Part of Android R platform (for 4.9+), but mainlined in S
static const set<string> PLATFORM_ONLY_IN_R = {
PLATFORM "map_offload_tether_ingress_map",
PLATFORM "map_offload_tether_limit_map",
@@ -128,17 +126,18 @@
SHARED "prog_dscpPolicy_schedcls_set_dscp_ether",
};
-void addAll(set<string>* a, const set<string>& b) {
- a->insert(b.begin(), b.end());
+static void addAll(set<string>& a, const set<string>& b) {
+ a.insert(b.begin(), b.end());
}
-#define DO_EXPECT(B, V) do { \
- if (B) addAll(expected, (V)); else addAll(unexpected, (V)); \
-} while (0)
+#define DO_EXPECT(B, V) addAll((B) ? mustExist : mustNotExist, (V))
-void getFileLists(set<string>* expected, set<string>* unexpected) {
- unexpected->clear();
- expected->clear();
+TEST_F(BpfExistenceTest, TestPrograms) {
+ // Only unconfined root is guaranteed to be able to access everything in /sys/fs/bpf.
+ ASSERT_EQ(0, getuid()) << "This test must run as root.";
+
+ set<string> mustExist;
+ set<string> mustNotExist;
// We do not actually check the platform P/Q (netd) and Q (clatd) things
// and only verify the mainline module relevant R+ offload maps & progs.
@@ -147,24 +146,23 @@
// and not to test the platform itself, which may have been modified by vendor or oems,
// so we should only test for the removal of stuff that was mainline'd,
// and for the presence of mainline stuff.
- DO_EXPECT(IsAtLeastR() && !IsAtLeastS(), PLATFORM_ONLY_IN_R);
+ // R can potentially run on pre-4.9 kernel non-eBPF capable devices.
+ DO_EXPECT(IsAtLeastR() && !IsAtLeastS() && isAtLeastKernelVersion(4, 9, 0), PLATFORM_ONLY_IN_R);
+
+ // S requires Linux Kernel 4.9+ and thus requires eBPF support.
DO_EXPECT(IsAtLeastS(), MAINLINE_FOR_S_PLUS);
DO_EXPECT(IsAtLeastS() && isAtLeastKernelVersion(5, 10, 0), MAINLINE_FOR_S_5_10_PLUS);
// Nothing added or removed in SCv2.
+ // T still only requires Linux Kernel 4.9+.
DO_EXPECT(IsAtLeastT(), MAINLINE_FOR_T_PLUS);
DO_EXPECT(IsAtLeastT() && isAtLeastKernelVersion(4, 14, 0), MAINLINE_FOR_T_4_14_PLUS);
DO_EXPECT(IsAtLeastT() && isAtLeastKernelVersion(5, 4, 0), MAINLINE_FOR_T_5_4_PLUS);
DO_EXPECT(IsAtLeastT() && isAtLeastKernelVersion(5, 15, 0), MAINLINE_FOR_T_5_15_PLUS);
-}
-void checkFiles() {
- set<string> mustExist;
- set<string> mustNotExist;
-
- getFileLists(&mustExist, &mustNotExist);
+ // U requires Linux Kernel 4.14+, but nothing (as yet) added or removed in U.
for (const auto& file : mustExist) {
EXPECT_EQ(0, access(file.c_str(), R_OK)) << file << " does not exist";
@@ -178,19 +176,3 @@
}
}
}
-
-TEST_F(BpfExistenceTest, TestPrograms) {
- SKIP_IF_BPF_NOT_SUPPORTED;
-
- // Pre-flight check to ensure test has been updated.
- uint64_t buildVersionSdk = android_get_device_api_level();
- ASSERT_NE(0, buildVersionSdk) << "Unable to determine device SDK version";
- if (buildVersionSdk > __ANDROID_API_T__ && buildVersionSdk != __ANDROID_API_FUTURE__) {
- FAIL() << "Unknown OS version " << buildVersionSdk << ", please update this test";
- }
-
- // Only unconfined root is guaranteed to be able to access everything in /sys/fs/bpf.
- ASSERT_EQ(0, getuid()) << "This test must run as root.";
-
- checkFiles();
-}