commit 1e4afe071ddca3283f3f9ffe79fbcebb16354864
author Chalard Jean <jchalard@google.com> Wed Oct 12 16:15:13 2022 +0900
committer Chalard Jean <jchalard@google.com> Wed Oct 12 16:15:13 2022 +0900
tree 9db8c68439d3656fbdc34d319dc4e373b81c1dd7
parent 6557144b32ca252d6c17b0732bba39e0d4980ee4

Fix an infinite loop

If the top bit is set, then >>= propagates it. That means
|bitmask| is never 0, and this is an infinite loop.

A followup will move this method to frameworks/libs/net
and add tests for it.

Test: FrameworksNetTests
Change-Id: I28a0a74be41f6f29b796b1c76e404ecc21f810c6

framework/src/android/net/NetworkCapabilities.java

diff --git a/framework/src/android/net/NetworkCapabilities.java b/framework/src/android/net/NetworkCapabilities.java
index ea8a3df..1ad3b9f 100644
--- a/framework/src/android/net/NetworkCapabilities.java
+++ b/framework/src/android/net/NetworkCapabilities.java
@@ -2308,7 +2308,7 @@
                 }
                 sb.append(nameFetcher.nameOf(bitPos));
             }
-            bitMask >>= 1;
+            bitMask >>>= 1;
             ++bitPos;
         }
     }