commit e86054e5c2e4734d87d2fbf1eeba8c75fc888df0
author Jean Chalard <jchalard@google.com> Fri Jun 08 22:21:20 2012 +0900
committer Jean Chalard <jchalard@google.com> Wed Jun 13 03:34:58 2012 +0900
tree 23da98790c62d07c92b468c557cbaa2bc9d962c6
parent 53eedaea925b41608585aa1c3025089c66a3367a

Consolidate a test.

Stop using the numerical value, use the actual method

Change-Id: Iffa7f2d21a0471c7862afd3234cc9c5dd86feb2e

java/src/com/android/inputmethod/latin/LatinIME.java

diff --git a/java/src/com/android/inputmethod/latin/LatinIME.java b/java/src/com/android/inputmethod/latin/LatinIME.java
index 4670bed..899c980 100644
--- a/java/src/com/android/inputmethod/latin/LatinIME.java
+++ b/java/src/com/android/inputmethod/latin/LatinIME.java
@@ -391,6 +391,8 @@
 
         Utils.GCUtils.getInstance().reset();
         boolean tryGC = true;
+        // Shouldn't this be removed? I think that from Honeycomb on, the GC is now actually working
+        // as expected and this code is useless.
         for (int i = 0; i < Utils.GCUtils.GC_TRY_LOOP_MAX && tryGC; ++i) {
             try {
                 initSuggest();
@@ -762,6 +764,7 @@
                     composingSpanEnd, mExpectingUpdateSelection,
                     expectingUpdateSelectionFromLogger, mConnection);
             if (expectingUpdateSelectionFromLogger) {
+                // TODO: Investigate. Quitting now sounds wrong - we won't do the resetting work
                 return;
             }
         }
@@ -1626,7 +1629,7 @@
     public boolean isSuggestionsRequested() {
         // TODO: move this method to mSettingsValues
         return mInputAttributes.mIsSettingsSuggestionStripOn
-                && (mCurrentSettings.mCorrectionMode > 0 || isShowingSuggestionsStrip());
+                && (mCurrentSettings.isCorrectionOn() || isShowingSuggestionsStrip());
     }
 
     public boolean isShowingPunctuationList() {