commit dafa7a8e15447544842975047f831883e67700c5
author Jean Chalard <jchalard@google.com> Tue Dec 13 21:12:07 2011 +0900
committer Jean Chalard <jchalard@google.com> Tue Dec 13 21:12:07 2011 +0900
tree 44cd905d1ac49d9e1d0f8363f8516ae80c6a2327
parent 7e6f4daa196f0fd88873b5b360e3fc11b97e1ef7

Remove the input connection sidework from handleCharacter

Change-Id: I3d376dfda3acd8864274390de3ff5752b18456e0

java/src/com/android/inputmethod/latin/LatinIME.java

diff --git a/java/src/com/android/inputmethod/latin/LatinIME.java b/java/src/com/android/inputmethod/latin/LatinIME.java
index a8f4e31..aa6ef06 100644
--- a/java/src/com/android/inputmethod/latin/LatinIME.java
+++ b/java/src/com/android/inputmethod/latin/LatinIME.java
@@ -1496,12 +1496,19 @@
     private void handleCharacter(final int primaryCode, final int[] keyCodes, final int x,
             final int y, final int spaceState) {
         mVoiceProxy.handleCharacter();
-
         final InputConnection ic = getCurrentInputConnection();
-        if (ic != null) ic.beginBatchEdit();
+        if (null != ic) ic.beginBatchEdit();
+        // TODO: if ic is null, does it make any sense to call this?
+        handleCharacterWhileInBatchEdit(primaryCode, keyCodes, x, y, spaceState, ic);
+        if (null != ic) ic.endBatchEdit();
+    }
+
+    // "ic" may be null without this crashing, but the behavior will be really strange
+    private void handleCharacterWhileInBatchEdit(final int primaryCode, final int[] keyCodes,
+            final int x, final int y, final int spaceState, final InputConnection ic) {
         if (SPACE_STATE_MAGIC == spaceState
                 && mSettingsValues.isMagicSpaceStripper(primaryCode)) {
-            removeTrailingSpaceWhileInBatchEdit(ic);
+            if (null != ic) removeTrailingSpaceWhileInBatchEdit(ic);
         }
 
         int code = primaryCode;
@@ -1520,7 +1527,6 @@
         if (switcher.isShiftedOrShiftLocked()) {
             if (keyCodes == null || keyCodes[0] < Character.MIN_CODE_POINT
                     || keyCodes[0] > Character.MAX_CODE_POINT) {
-                if (null != ic) ic.endBatchEdit();
                 return;
             }
             code = keyCodes[0];
@@ -1534,7 +1540,6 @@
                 } else {
                     // Some keys, such as [eszett], have upper case as multi-characters.
                     onTextInput(upperCaseString);
-                    if (null != ic) ic.endBatchEdit();
                     return;
                 }
             }
@@ -1564,7 +1569,6 @@
         } else {
             Utils.Stats.onNonSeparator((char)code, x, y);
         }
-        if (null != ic) ic.endBatchEdit();
     }
 
     private void handleSeparator(final int primaryCode, final int x, final int y,