commit d78b586976af9b6b8f6e00c04747facfac313abc
author Tadashi G. Takaoka <takaoka@google.com> Mon Jun 02 18:43:07 2014 +0900
committer Tadashi G. Takaoka <takaoka@google.com> Mon Jun 02 18:53:58 2014 +0900
tree 561c25dc56a075bcd08b7c1e787eb21c14a8dc9e
parent a021395e84d4a934c042c56ef03f352cf43463f3

Create AccessibilityDelegate only when accessibility mode is on

Change-Id: I4cbae476d16723778b46ff765dd97832f279785f

java/src/com/android/inputmethod/keyboard/MainKeyboardView.java

diff --git a/java/src/com/android/inputmethod/keyboard/MainKeyboardView.java b/java/src/com/android/inputmethod/keyboard/MainKeyboardView.java
index 95258cc..495cfa9 100644
--- a/java/src/com/android/inputmethod/keyboard/MainKeyboardView.java
+++ b/java/src/com/android/inputmethod/keyboard/MainKeyboardView.java
@@ -161,10 +161,9 @@
     private final TimerHandler mKeyTimerHandler;
     private final int mLanguageOnSpacebarHorizontalMargin;
 
-    private final DrawingHandler mDrawingHandler =
-            new DrawingHandler(this);
+    private final DrawingHandler mDrawingHandler = new DrawingHandler(this);
 
-    private final MainKeyboardAccessibilityDelegate mAccessibilityDelegate;
+    private MainKeyboardAccessibilityDelegate mAccessibilityDelegate;
 
     public MainKeyboardView(final Context context, final AttributeSet attrs) {
         this(context, attrs, R.attr.mainKeyboardViewStyle);
@@ -262,8 +261,6 @@
 
         mLanguageOnSpacebarHorizontalMargin = (int)getResources().getDimension(
                 R.dimen.config_language_on_spacebar_horizontal_margin);
-
-        mAccessibilityDelegate = new MainKeyboardAccessibilityDelegate(this, mKeyDetector);
     }
 
     @Override
@@ -384,7 +381,14 @@
         final int keyHeight = keyboard.mMostCommonKeyHeight - keyboard.mVerticalGap;
         mLanguageOnSpacebarTextSize = keyHeight * mLanguageOnSpacebarTextRatio;
 
-        mAccessibilityDelegate.setKeyboard(keyboard);
+        final MainKeyboardAccessibilityDelegate accessibilityDelegate;
+        if (AccessibilityUtils.getInstance().isAccessibilityEnabled()) {
+            accessibilityDelegate = new MainKeyboardAccessibilityDelegate(this, mKeyDetector);
+            accessibilityDelegate.setKeyboard(keyboard);
+        } else {
+            accessibilityDelegate = null;
+        }
+        mAccessibilityDelegate = accessibilityDelegate;
     }
 
     /**
@@ -726,8 +730,9 @@
     }
 
     public void onHideWindow() {
-        if (AccessibilityUtils.getInstance().isAccessibilityEnabled()) {
-            mAccessibilityDelegate.onHideWindow();
+        final MainKeyboardAccessibilityDelegate accessibilityDelegate = mAccessibilityDelegate;
+        if (accessibilityDelegate != null) {
+            accessibilityDelegate.onHideWindow();
         }
     }
 
@@ -736,8 +741,9 @@
      */
     @Override
     public boolean onHoverEvent(final MotionEvent event) {
-        if (AccessibilityUtils.getInstance().isTouchExplorationEnabled()) {
-            return mAccessibilityDelegate.onHoverEvent(event);
+        final MainKeyboardAccessibilityDelegate accessibilityDelegate = mAccessibilityDelegate;
+        if (accessibilityDelegate != null) {
+            return accessibilityDelegate.onHoverEvent(event);
         }
         return super.onHoverEvent(event);
     }