commit bba39b9b678f4fb00511ba88c12eef9082ecc628
author Kurt Partridge <kep@google.com> Wed Feb 27 14:13:29 2013 -0800
committer Kurt Partridge <kep@google.com> Thu Mar 07 17:43:35 2013 -0800
tree be7fd4601971954054ee1d420dabec4ad3d930db
parent ee3261ff558ee734e15af5424f98bb8d8776795f

[FileEncap8] Remove useless "success" variable

Change-Id: Icf76bc0b795b6a9221d9a6d61c38df31af54ab7b

java/src/com/android/inputmethod/research/Uploader.java

diff --git a/java/src/com/android/inputmethod/research/Uploader.java b/java/src/com/android/inputmethod/research/Uploader.java
index ac64076..df495a8 100644
--- a/java/src/com/android/inputmethod/research/Uploader.java
+++ b/java/src/com/android/inputmethod/research/Uploader.java
@@ -116,23 +116,15 @@
                         && !pathname.canWrite();
             }
         });
-        // TODO: Remove local variable
-        boolean success = true;
-        if (files.length == 0) {
-            success = false;
-        }
         for (final File file : files) {
-            if (!uploadFile(file)) {
-                success = false;
-            }
+            uploadFile(file);
         }
     }
 
-    private boolean uploadFile(final File file) {
+    private void uploadFile(final File file) {
         if (DEBUG) {
             Log.d(TAG, "attempting upload of " + file.getAbsolutePath());
         }
-        boolean success = false;
         final int contentLength = (int) file.length();
         HttpURLConnection connection = null;
         InputStream fileInputStream = null;
@@ -154,10 +146,9 @@
                     Log.d(TAG, "| " + reader.readLine());
                 }
                 reader.close();
-                return success;
+                return;
             }
             file.delete();
-            success = true;
             if (DEBUG) {
                 Log.d(TAG, "upload successful");
             }
@@ -175,7 +166,6 @@
                 connection.disconnect();
             }
         }
-        return success;
     }
 
     private static void uploadContents(final InputStream is, final OutputStream os)