commit ae0c109d11c394cc5d2fa26b851186e0315c88bf
author Jean Chalard <jchalard@google.com> Fri Dec 16 13:05:43 2011 +0900
committer Jean Chalard <jchalard@google.com> Fri Dec 16 18:04:39 2011 +0900
tree 9bbca2628e505bb3f456741769b11ef3878775bc
parent 4e8922f1bed5bf5d59275c6f84a72790423a88bf

Make insertSpaceOnPickSuggestionManually final.

Change-Id: I32fce0ea8c5c58b6f920d0758c8bf57769f39a12

java/src/com/android/inputmethod/latin/LatinIME.java

diff --git a/java/src/com/android/inputmethod/latin/LatinIME.java b/java/src/com/android/inputmethod/latin/LatinIME.java
index 3ea3c36..abe6dfb 100644
--- a/java/src/com/android/inputmethod/latin/LatinIME.java
+++ b/java/src/com/android/inputmethod/latin/LatinIME.java
@@ -798,28 +798,30 @@
     private void initializeInputAttributes(final EditorInfo editorInfo) {
         mInputAttributes = new InputAttributes(editorInfo);
 
-        boolean insertSpaceOnPickSuggestionManually = false;
+        final boolean insertSpaceOnPickSuggestionManually;
         boolean inputTypeNoAutoCorrect = false;
         boolean isSettingsSuggestionStripOn = false;
         boolean applicationSpecifiedCompletionOn = false;
 
-        if (editorInfo == null)
-            return;
-        final int inputType = editorInfo.inputType;
-        if (inputType == InputType.TYPE_NULL) {
-            // TODO: We should honor TYPE_NULL specification.
-            Log.i(TAG, "InputType.TYPE_NULL is specified");
-        }
-        final int inputClass = inputType & InputType.TYPE_MASK_CLASS;
-        final int variation = inputType & InputType.TYPE_MASK_VARIATION;
-        if (inputClass == 0) {
-            Log.w(TAG, String.format("Unexpected input class: inputType=0x%08x imeOptions=0x%08x",
-                    inputType, editorInfo.imeOptions));
-        }
+        if (editorInfo == null || editorInfo.inputType != InputType.TYPE_CLASS_TEXT) {
+            if (editorInfo.inputType == InputType.TYPE_NULL) {
+                // TODO: We should honor TYPE_NULL specification.
+                Log.i(TAG, "InputType.TYPE_NULL is specified");
+            }
+            mApplicationSpecifiedCompletions = null;
+            insertSpaceOnPickSuggestionManually = false;
+        } else {
+            final int inputType = editorInfo.inputType;
+            final int inputClass = inputType & InputType.TYPE_MASK_CLASS;
+            final int variation = inputType & InputType.TYPE_MASK_VARIATION;
+            if (inputClass == 0) {
+                Log.w(TAG, String.format("Unexpected input class: inputType=0x%08x"
+                        + " imeOptions=0x%08x",
+                        inputType, editorInfo.imeOptions));
+            }
 
-        mApplicationSpecifiedCompletions = null;
+            mApplicationSpecifiedCompletions = null;
 
-        if (inputClass == InputType.TYPE_CLASS_TEXT) {
             isSettingsSuggestionStripOn = true;
             // Make sure that passwords are not displayed in {@link SuggestionsView}.
             if (InputTypeCompatUtils.isPasswordInputType(inputType)