commit 77e26e1c29632b73997cfaea9cd9ebb57a2dea73
author Jean Chalard <jchalard@google.com> Thu Apr 18 23:11:43 2013 +0900
committer Jean Chalard <jchalard@google.com> Thu Apr 18 23:14:13 2013 +0900
tree 3eef4a6d2627147bdd2f66f81c5f3dee28fb698c
parent 530fd15eff8bd8df1c4c87cfeab379b5328748c1

Fix an infinite loop

What do you mean "Can't happen"?
It happens all the time - the empty string is the default ID, and it
needs to be updated like everyone else.

Bug: 8651858
Change-Id: I5a2f2ebb5b2ef08b27f26be8fb2c3d2f231ebcfc

java/src/com/android/inputmethod/dictionarypack/UpdateHandler.java

diff --git a/java/src/com/android/inputmethod/dictionarypack/UpdateHandler.java b/java/src/com/android/inputmethod/dictionarypack/UpdateHandler.java
index e05a79b..3173e91 100644
--- a/java/src/com/android/inputmethod/dictionarypack/UpdateHandler.java
+++ b/java/src/com/android/inputmethod/dictionarypack/UpdateHandler.java
@@ -181,7 +181,6 @@
             if (!cursor.moveToFirst()) return;
             do {
                 final String clientId = cursor.getString(0);
-                if (TextUtils.isEmpty(clientId)) continue; // This probably can't happen
                 final String metadataUri =
                         MetadataDbHelper.getMetadataUriAsString(context, clientId);
                 PrivateLog.log("Update for clientId " + Utils.s(clientId), context);