commit 620ebde70490473fd3562f70d1f24d7d53b6fb1c
author Keisuke Kuroyanagi <ksk@google.com> Wed Oct 08 12:18:29 2014 +0900
committer Keisuke Kuroyanagi <ksk@google.com> Thu Oct 09 21:28:40 2014 +0900
tree 25fe5d5f27186b6e847cbbcaea034ab0cb3dd0c1
parent 45783013bf92bb77df01ad842e93310f8a057552

Make members of classes that are used with std::vector const

Change-Id: Id93fb87f5630230fc3f9cd339e12f3b0e2006ea9

native/jni/src/suggest/core/dictionary/property/historical_info.h

diff --git a/native/jni/src/suggest/core/dictionary/property/historical_info.h b/native/jni/src/suggest/core/dictionary/property/historical_info.h
index 5ed9ebf..f9bd6fd 100644
--- a/native/jni/src/suggest/core/dictionary/property/historical_info.h
+++ b/native/jni/src/suggest/core/dictionary/property/historical_info.h
@@ -47,12 +47,12 @@
     }
 
  private:
-    // Default copy constructor and assign operator are used for using in std::vector.
+    // Default copy constructor is used for using in std::vector.
+    DISALLOW_ASSIGNMENT_OPERATOR(HistoricalInfo);
 
-    // TODO: Make members const.
-    int mTimestamp;
-    int mLevel;
-    int mCount;
+    const int mTimestamp;
+    const int mLevel;
+    const int mCount;
 };
 } // namespace latinime
 #endif /* LATINIME_HISTORICAL_INFO_H */

native/jni/src/suggest/core/dictionary/property/ngram_property.h

diff --git a/native/jni/src/suggest/core/dictionary/property/ngram_property.h b/native/jni/src/suggest/core/dictionary/property/ngram_property.h
index dce4600..8709799 100644
--- a/native/jni/src/suggest/core/dictionary/property/ngram_property.h
+++ b/native/jni/src/suggest/core/dictionary/property/ngram_property.h
@@ -44,13 +44,13 @@
     }
 
  private:
-    // Default copy constructor and assign operator are used for using in std::vector.
+    // Default copy constructor is used for using in std::vector.
     DISALLOW_DEFAULT_CONSTRUCTOR(NgramProperty);
+    DISALLOW_ASSIGNMENT_OPERATOR(NgramProperty);
 
-    // TODO: Make members const.
-    std::vector<int> mTargetCodePoints;
-    int mProbability;
-    HistoricalInfo mHistoricalInfo;
+    const std::vector<int> mTargetCodePoints;
+    const int mProbability;
+    const HistoricalInfo mHistoricalInfo;
 };
 } // namespace latinime
 #endif // LATINIME_NGRAM_PROPERTY_H

native/jni/src/suggest/core/dictionary/property/unigram_property.h

diff --git a/native/jni/src/suggest/core/dictionary/property/unigram_property.h b/native/jni/src/suggest/core/dictionary/property/unigram_property.h
index d1f0ab4..5ed2e26 100644
--- a/native/jni/src/suggest/core/dictionary/property/unigram_property.h
+++ b/native/jni/src/suggest/core/dictionary/property/unigram_property.h
@@ -41,12 +41,11 @@
         }
 
      private:
-        // Default copy constructor and assign operator are used for using in std::vector.
+        // Default copy constructor is used for using in std::vector.
         DISALLOW_DEFAULT_CONSTRUCTOR(ShortcutProperty);
 
-        // TODO: Make members const.
-        std::vector<int> mTargetCodePoints;
-        int mProbability;
+        const std::vector<int> mTargetCodePoints;
+        const int mProbability;
     };
 
     UnigramProperty()
@@ -104,13 +103,12 @@
     // Default copy constructor is used for using as a return value.
     DISALLOW_ASSIGNMENT_OPERATOR(UnigramProperty);
 
-    // TODO: Make members const.
-    bool mRepresentsBeginningOfSentence;
-    bool mIsNotAWord;
-    bool mIsBlacklisted;
-    int mProbability;
-    HistoricalInfo mHistoricalInfo;
-    std::vector<ShortcutProperty> mShortcuts;
+    const bool mRepresentsBeginningOfSentence;
+    const bool mIsNotAWord;
+    const bool mIsBlacklisted;
+    const int mProbability;
+    const HistoricalInfo mHistoricalInfo;
+    const std::vector<ShortcutProperty> mShortcuts;
 };
 } // namespace latinime
 #endif // LATINIME_UNIGRAM_PROPERTY_H