commit 61dbda00de17be4b624ee7830ae4859167db3ed1
author Tadashi G. Takaoka <takaoka@google.com> Fri Mar 28 16:29:56 2014 +0900
committer Tadashi G. Takaoka <takaoka@google.com> Fri Mar 28 17:56:08 2014 +0900
tree f8d4750cbe51b5b8e885b8e887d699be8d3e5367
parent f173b12b03a46cb086d61b6a39334c8c9c528281

Remove redundant check to detect forceAscii

Change-Id: Ib3272ec19a90b3aa4937573e049ceb86855ea408

java/src/com/android/inputmethod/keyboard/KeyboardSwitcher.java

diff --git a/java/src/com/android/inputmethod/keyboard/KeyboardSwitcher.java b/java/src/com/android/inputmethod/keyboard/KeyboardSwitcher.java
index 2dfde94..37a4bf8 100644
--- a/java/src/com/android/inputmethod/keyboard/KeyboardSwitcher.java
+++ b/java/src/com/android/inputmethod/keyboard/KeyboardSwitcher.java
@@ -205,7 +205,7 @@
         final boolean subtypeChanged = (oldKeyboard == null)
                 || !keyboard.mId.mLocale.equals(oldKeyboard.mId.mLocale);
         final boolean needsToDisplayLanguage = mSubtypeSwitcher.needsToDisplayLanguage(
-                keyboard.mId.mLocale);
+                keyboard.mId.mSubtype);
         keyboardView.startDisplayLanguageOnSpacebar(subtypeChanged, needsToDisplayLanguage,
                 RichInputMethodManager.getInstance().hasMultipleEnabledIMEsOrSubtypes(true));
     }

java/src/com/android/inputmethod/latin/SubtypeSwitcher.java

diff --git a/java/src/com/android/inputmethod/latin/SubtypeSwitcher.java b/java/src/com/android/inputmethod/latin/SubtypeSwitcher.java
index 935dd96..c9a85f9 100644
--- a/java/src/com/android/inputmethod/latin/SubtypeSwitcher.java
+++ b/java/src/com/android/inputmethod/latin/SubtypeSwitcher.java
@@ -93,7 +93,10 @@
         private int mEnabledSubtypeCount;
         private boolean mIsSystemLanguageSameAsInputLanguage;
 
-        public boolean getValue() {
+        public boolean needsToDisplayLanguage(final InputMethodSubtype subtype) {
+            if (SubtypeLocaleUtils.isNoLanguage(subtype)) {
+                return true;
+            }
             return mEnabledSubtypeCount >= 2 || !mIsSystemLanguageSameAsInputLanguage;
         }
 
@@ -265,14 +268,8 @@
     // Subtype Switching functions //
     //////////////////////////////////
 
-    public boolean needsToDisplayLanguage(final Locale keyboardLocale) {
-        if (keyboardLocale.toString().equals(SubtypeLocaleUtils.NO_LANGUAGE)) {
-            return true;
-        }
-        if (!keyboardLocale.equals(getCurrentSubtypeLocale())) {
-            return false;
-        }
-        return mNeedsToDisplayLanguage.getValue();
+    public boolean needsToDisplayLanguage(final InputMethodSubtype subtype) {
+        return mNeedsToDisplayLanguage.needsToDisplayLanguage(subtype);
     }
 
     public boolean isSystemLocaleSameAsLocaleOfAllEnabledSubtypesOfEnabledImes() {