commit 5e4e05afd2825bf7acb594fef5e7bd21c751dd63
author Tadashi G. Takaoka <takaoka@google.com> Sat Jun 18 13:33:48 2011 +0900
committer Tadashi G. Takaoka <takaoka@google.com> Sat Jun 18 23:43:58 2011 +0900
tree bd5988fa0a3c43d8b0a52c99a023459746423e13
parent c029e0f4a721f0e9972a4669707ad70b079899e4

Fix NPE

Bug: 4686479
Change-Id: I0b8a32d0f9bcebe55eebecd38dc5e69198e94378

java/src/com/android/inputmethod/keyboard/KeyboardSwitcher.java

diff --git a/java/src/com/android/inputmethod/keyboard/KeyboardSwitcher.java b/java/src/com/android/inputmethod/keyboard/KeyboardSwitcher.java
index 50c61ff..af22208 100644
--- a/java/src/com/android/inputmethod/keyboard/KeyboardSwitcher.java
+++ b/java/src/com/android/inputmethod/keyboard/KeyboardSwitcher.java
@@ -782,11 +782,15 @@
     }
 
     public void onAutoCorrectionStateChanged(boolean isAutoCorrection) {
-        if (isAutoCorrection != mIsAutoCorrectionActive) {
-            LatinKeyboardView keyboardView = getKeyboardView();
+        if (mIsAutoCorrectionActive != isAutoCorrection) {
             mIsAutoCorrectionActive = isAutoCorrection;
-            keyboardView.invalidateKey(((LatinKeyboard) keyboardView.getKeyboard())
-                    .onAutoCorrectionStateChanged(isAutoCorrection));
+            final LatinKeyboard keyboard = getLatinKeyboard();
+            if (keyboard != null && keyboard.needsAutoCorrectionSpacebarLed()) {
+                final Key invalidatedKey = keyboard.onAutoCorrectionStateChanged(isAutoCorrection);
+                final LatinKeyboardView keyboardView = getKeyboardView();
+                if (keyboardView != null)
+                    keyboardView.invalidateKey(invalidatedKey);
+            }
         }
     }
 

java/src/com/android/inputmethod/latin/LatinIME.java

diff --git a/java/src/com/android/inputmethod/latin/LatinIME.java b/java/src/com/android/inputmethod/latin/LatinIME.java
index fc01d39..7446aff 100644
--- a/java/src/com/android/inputmethod/latin/LatinIME.java
+++ b/java/src/com/android/inputmethod/latin/LatinIME.java
@@ -1459,16 +1459,10 @@
     }
 
     public void setSuggestions(SuggestedWords words) {
-//        if (mVoiceProxy.getAndResetIsShowingHint()) {
-//             setCandidatesView(mCandidateViewContainer);
-//        }
-
         if (mCandidateView != null) {
             mCandidateView.setSuggestions(words);
-            if (mKeyboardSwitcher.getLatinKeyboard().needsAutoCorrectionSpacebarLed()) {
-                mKeyboardSwitcher.onAutoCorrectionStateChanged(
-                        words.hasWordAboveAutoCorrectionScoreThreshold());
-            }
+            mKeyboardSwitcher.onAutoCorrectionStateChanged(
+                    words.hasWordAboveAutoCorrectionScoreThreshold());
         }
     }