| commit | 01d47b809617aee03e240a6b4b41013269547bc1 | [log] [tgz] |
|---|---|---|
| author | Jean Chalard <jchalard@google.com> | Fri Nov 09 19:16:37 2012 +0900 |
| committer | Jean Chalard <jchalard@google.com> | Fri Nov 09 19:16:37 2012 +0900 |
| tree | cda12f3118bbc7e731ba508fa3cc50102457a7cb | |
| parent | 710d06cea91a8e6bf04a27f0bcd88d76a5cc5acd [diff] |
Fix a logic flaw. This test is seriously wrong : although we do have a method that does exactly the right thing, this looks at a very specific, unrelated variable state in hope it happens to be set only in the relevant cases by the play of logic. I don't think this changes anything concretely, as the assumption was probably true in the practice ; still, this code is very hard to read and prone to unexpected breakage. Change-Id: I77ab576f90762429fcc752df31ed30e1c81871dc