commit 51e79fb4b2025985f7cc29f43357d60c6889e3ff
author Jean Chalard <jchalard@google.com> Fri Dec 27 07:56:56 2013 +0000
committer Android (Google) Code Review <android-gerrit@google.com> Fri Dec 27 07:56:56 2013 +0000
tree 2d1abdee31e739b766fb145e9876b751f833de24
parent 2fc1cc099f27442c9a3f93f8a49dd333c83a2abe
parent 71a3e96382a0564e32b6679e23f82f2413031310

Merge "[IL46] Remove a useless message passing."

java/src/com/android/inputmethod/latin/LatinIME.java

diff --git a/java/src/com/android/inputmethod/latin/LatinIME.java b/java/src/com/android/inputmethod/latin/LatinIME.java
index f90cf2f..0529eca 100644
--- a/java/src/com/android/inputmethod/latin/LatinIME.java
+++ b/java/src/com/android/inputmethod/latin/LatinIME.java
@@ -1302,19 +1302,12 @@
             mLatinIme = latinIme;
         }
 
-        private static final int MSG_UPDATE_GESTURE_PREVIEW_AND_SUGGESTION_STRIP = 1;
-        private static final int MSG_GET_SUGGESTED_WORDS = 2;
+        private static final int MSG_GET_SUGGESTED_WORDS = 1;
 
         // Called on the InputUpdater thread by the Handler code.
         @Override
         public boolean handleMessage(final Message msg) {
-            // TODO: straighten message passing - we don't need two kinds of messages calling
-            // each other.
             switch (msg.what) {
-                case MSG_UPDATE_GESTURE_PREVIEW_AND_SUGGESTION_STRIP:
-                    updateBatchInput((InputPointers)msg.obj, msg.arg2 /* sequenceNumber */,
-                            false /* forEnd */);
-                    break;
                 case MSG_GET_SUGGESTED_WORDS:
                     mLatinIme.getSuggestedWords(msg.arg1 /* sessionId */,
                             msg.arg2 /* sequenceNumber */, (OnGetSuggestedWordsCallback) msg.obj);
@@ -1326,7 +1319,6 @@
         // Called on the UI thread by LatinIME.
         public void onStartBatchInput() {
             synchronized (mLock) {
-                mHandler.removeMessages(MSG_UPDATE_GESTURE_PREVIEW_AND_SUGGESTION_STRIP);
                 mInBatchInput = true;
             }
         }
@@ -1345,7 +1337,6 @@
         private void updateBatchInput(final InputPointers batchPointers,
                 final int sequenceNumber, final boolean forEnd) {
             synchronized (mLock) {
-                mHandler.removeMessages(MSG_UPDATE_GESTURE_PREVIEW_AND_SUGGESTION_STRIP);
                 if (!mInBatchInput) {
                     // Batch input has ended or canceled while the message was being delivered.
                     return;
@@ -1382,14 +1373,7 @@
         // Called on the UI thread by LatinIME.
         public void onUpdateBatchInput(final InputPointers batchPointers,
                 final int sequenceNumber) {
-            synchronized (mLock) {
-                if (mHandler.hasMessages(MSG_UPDATE_GESTURE_PREVIEW_AND_SUGGESTION_STRIP)) {
-                    return;
-                }
-                mHandler.obtainMessage(MSG_UPDATE_GESTURE_PREVIEW_AND_SUGGESTION_STRIP,
-                        0 /* arg1 */,sequenceNumber /* arg2 */,
-                        batchPointers /* obj */).sendToTarget();
-            }
+            updateBatchInput(batchPointers, sequenceNumber, false /* forEnd */);
         }
 
         /**
@@ -1402,7 +1386,6 @@
         // Called on the UI thread by LatinIME.
         public void onCancelBatchInput() {
             synchronized (mLock) {
-                mHandler.removeMessages(MSG_UPDATE_GESTURE_PREVIEW_AND_SUGGESTION_STRIP);
                 mInBatchInput = false;
             }
         }
@@ -1450,7 +1433,6 @@
 
         void quitLooper() {
             mHandler.removeMessages(MSG_GET_SUGGESTED_WORDS);
-            mHandler.removeMessages(MSG_UPDATE_GESTURE_PREVIEW_AND_SUGGESTION_STRIP);
             mHandler.getLooper().quit();
         }
     }