commit 466e665b3cfdaee0f6149d16d5244b54ddb86838
author Kurt Partridge <kep@google.com> Wed Feb 27 12:13:42 2013 -0800
committer Kurt Partridge <kep@google.com> Wed Mar 06 07:19:41 2013 -0800
tree 973e143f78d3a7e3d1e49dfeedcca7636a8a9b8d
parent 347b2ebebf63e6958817364f7194a084aebe996f

[FileEncap2] Remove mCanUpload instance variable

Change-Id: I62a100c4d73bb64a14a7994f7dd9af7b6946d064

java/src/com/android/inputmethod/research/UploaderService.java

diff --git a/java/src/com/android/inputmethod/research/UploaderService.java b/java/src/com/android/inputmethod/research/UploaderService.java
index 7acd79d..ed195ba 100644
--- a/java/src/com/android/inputmethod/research/UploaderService.java
+++ b/java/src/com/android/inputmethod/research/UploaderService.java
@@ -56,7 +56,6 @@
     private static final int BUF_SIZE = 1024 * 8;
     protected static final int TIMEOUT_IN_MS = 1000 * 4;
 
-    private boolean mCanUpload;
     private File mFilesDir;
     private URL mUrl;
 
@@ -68,7 +67,6 @@
     public void onCreate() {
         super.onCreate();
 
-        mCanUpload = false;
         mFilesDir = null;
         mUrl = null;
 
@@ -83,12 +81,15 @@
             }
             mFilesDir = getFilesDir();
             mUrl = new URL(urlString);
-            mCanUpload = true;
         } catch (MalformedURLException e) {
             e.printStackTrace();
         }
     }
 
+    public boolean isPossibleToUpload() {
+        return hasUploadingPermission() && mUrl != null && !IS_INHIBITING_AUTO_UPLOAD;
+    }
+
     private boolean hasUploadingPermission() {
         final PackageManager packageManager = getPackageManager();
         return packageManager.checkPermission(Manifest.permission.INTERNET,
@@ -97,9 +98,7 @@
 
     @Override
     protected void onHandleIntent(Intent intent) {
-        if (!mCanUpload) {
-            return;
-        }
+        if (!isPossibleToUpload()) return;
         boolean isUploadingUnconditionally = false;
         Bundle bundle = intent.getExtras();
         if (bundle != null && bundle.containsKey(EXTRA_UPLOAD_UNCONDITIONALLY)) {