commit 45eb5d924d245618ec6066f631a99779617de057
author Tadashi G. Takaoka <takaoka@google.com> Sun Feb 09 22:01:23 2014 +0900
committer Tadashi G. Takaoka <takaoka@google.com> Sun Feb 09 23:45:23 2014 +0900
tree 12ba103346c3246477a5c3d64e84a11e8c00d56a
parent c44cbf6a3df629d79d720de034255cd98e48c28a

Allow an empty keySpec for Spacer

Bug: 12933248
Change-Id: I76432556caf319ce23c1fb7fa3d6b94118e64cf8

java/src/com/android/inputmethod/keyboard/Key.java

diff --git a/java/src/com/android/inputmethod/keyboard/Key.java b/java/src/com/android/inputmethod/keyboard/Key.java
index 1c8bada..aade490 100644
--- a/java/src/com/android/inputmethod/keyboard/Key.java
+++ b/java/src/com/android/inputmethod/keyboard/Key.java
@@ -316,8 +316,10 @@
         mActionFlags = actionFlags;
 
         final String keySpec = style.getString(keyAttr, R.styleable.Keyboard_Key_keySpec);
-        if (TextUtils.isEmpty(keySpec)) {
-            throw new RuntimeException("Empty keySpec");
+        // Note: {@link Spacer} has an empty keySpec.
+        // TODO: Create a Key constructor that parses only key geometries and share it with Spacer.
+        if (TextUtils.isEmpty(keySpec) && !(this instanceof Spacer)) {
+            throw new RuntimeException("Empty keySpec found in " + getClass().getName());
         }
 
         mIconId = KeySpecParser.getIconId(keySpec);