commit 41c471d93d117a65a4f241e588154d84709cf5d0
author Kurt Partridge <kep@google.com> Wed Mar 06 20:59:03 2013 +0000
committer Android (Google) Code Review <android-gerrit@google.com> Wed Mar 06 20:59:04 2013 +0000
tree b0fc0e87c85a4284a2d70759197f0f29b53c7537
parent 1bc20700d594af28bb87575df4279b0bed624c52
parent 9283644c41bf702217168a1750aa82954a4f3f47

Merge "[FileEncap5] Move conditional logic to caller"

java/src/com/android/inputmethod/research/UploaderService.java

diff --git a/java/src/com/android/inputmethod/research/UploaderService.java b/java/src/com/android/inputmethod/research/UploaderService.java
index bb70c43..eb5bdef 100644
--- a/java/src/com/android/inputmethod/research/UploaderService.java
+++ b/java/src/com/android/inputmethod/research/UploaderService.java
@@ -99,7 +99,9 @@
     @Override
     protected void onHandleIntent(Intent intent) {
         if (!isPossibleToUpload()) return;
-        doUpload(isUploadingUnconditionally(intent.getExtras()));
+        if (isUploadingUnconditionally(intent.getExtras()) || isConvenientToUpload()) {
+            doUpload();
+        }
     }
 
     private boolean isUploadingUnconditionally(final Bundle bundle) {
@@ -129,8 +131,7 @@
         return wifiInfo.isConnected();
     }
 
-    private void doUpload(final boolean isUploadingUnconditionally) {
-        if (!(isUploadingUnconditionally || isConvenientToUpload())) return;
+    private void doUpload() {
         if (mFilesDir == null) {
             return;
         }