commit 2d3e121014a97b7de90f287f1ef82fa98f37007c
author Satoshi Kataoka <satok@google.com> Tue Oct 08 18:54:24 2013 +0900
committer Satoshi Kataoka <satok@google.com> Tue Oct 08 19:05:00 2013 +0900
tree 99873ab6e43987c9a68a1b910ccdce0e42b5c7a2
parent d900b90db7d411c8cfc8ff9e41518bf98f50daff

Fix memory leak in EmojiPaletteView

Bug: 10902556
Change-Id: I3a8c1e08d6f953b462d914acd1f411c36f9d80f2

java/src/com/android/inputmethod/keyboard/EmojiPalettesView.java

diff --git a/java/src/com/android/inputmethod/keyboard/EmojiPalettesView.java b/java/src/com/android/inputmethod/keyboard/EmojiPalettesView.java
index ef9448c..5c518b8 100644
--- a/java/src/com/android/inputmethod/keyboard/EmojiPalettesView.java
+++ b/java/src/com/android/inputmethod/keyboard/EmojiPalettesView.java
@@ -694,13 +694,16 @@
         @Override
         public void destroyItem(final ViewGroup container, final int position,
                 final Object object) {
-            ScrollKeyboardView keyboardView = mActiveKeyboardViews.get(position);
+            final ScrollKeyboardView keyboardView = mActiveKeyboardViews.get(position);
             if (keyboardView != null) {
                 keyboardView.deallocateMemory();
                 mActiveKeyboardViews.remove(position);
             }
-            container.removeView(keyboardView);
-            keyboardView = null;
+            if (object instanceof View) {
+                container.removeView((View)object);
+            } else {
+                Log.w(TAG, "Warning!!! Emoji palette may be leaking. " + object);
+            }
         }
     }