commit 216fb6a0429162b2c6ee108d11117bbf4f7cc350
author Tadashi G. Takaoka <takaoka@google.com> Mon Apr 15 16:21:42 2013 +0900
committer Tadashi G. Takaoka <takaoka@google.com> Mon Apr 15 16:26:40 2013 +0900
tree a15c790cd0c2d9d3221a9be8d657af1dd8493544
parent 1ec4c07a13447a98deca1fc9e79f5d507030695d

Remove unnecessary harmful finish() from SettingsActivity

Bug: 8560722
Change-Id: I825b135bd13aca17e712330660978b834648dbc3

java/src/com/android/inputmethod/latin/SettingsFragment.java

diff --git a/java/src/com/android/inputmethod/latin/SettingsFragment.java b/java/src/com/android/inputmethod/latin/SettingsFragment.java
index 4c729ec..a96c997 100644
--- a/java/src/com/android/inputmethod/latin/SettingsFragment.java
+++ b/java/src/com/android/inputmethod/latin/SettingsFragment.java
@@ -16,7 +16,6 @@
 
 package com.android.inputmethod.latin;
 
-import android.app.Activity;
 import android.app.backup.BackupManager;
 import android.content.Context;
 import android.content.Intent;
@@ -115,12 +114,8 @@
             if (FeedbackUtils.isFeedbackFormSupported()) {
                 feedbackSettings.setOnPreferenceClickListener(new OnPreferenceClickListener() {
                     @Override
-                    public boolean onPreferenceClick(Preference arg0) {
-                        final Activity activity = getActivity();
-                        FeedbackUtils.showFeedbackForm(activity);
-                        if (!activity.isFinishing()) {
-                            activity.finish();
-                        }
+                    public boolean onPreferenceClick(final Preference pref) {
+                        FeedbackUtils.showFeedbackForm(getActivity());
                         return true;
                     }
                 });