commit 1a42236a8b22e0d3ca6f26704f052b8f83c991c5
author Tadashi G. Takaoka <takaoka@google.com> Mon Apr 15 00:35:26 2013 -0700
committer Android Git Automerger <android-git-automerger@android.com> Mon Apr 15 00:35:26 2013 -0700
tree c441db2d0bb6bedfed40a05f7fea60f8aa133919
parent 5f6492c584699fea5c5793f11b71df4b394c31c9
parent 4b6756db3c3ab982daaf378bc9677c8a1e26ece0

am 4b6756db: Merge "Remove unnecessary harmful finish() from SettingsActivity"

* commit '4b6756db3c3ab982daaf378bc9677c8a1e26ece0':
  Remove unnecessary harmful finish() from SettingsActivity

java/src/com/android/inputmethod/latin/SettingsFragment.java

diff --git a/java/src/com/android/inputmethod/latin/SettingsFragment.java b/java/src/com/android/inputmethod/latin/SettingsFragment.java
index 4c729ec..a96c997 100644
--- a/java/src/com/android/inputmethod/latin/SettingsFragment.java
+++ b/java/src/com/android/inputmethod/latin/SettingsFragment.java
@@ -16,7 +16,6 @@
 
 package com.android.inputmethod.latin;
 
-import android.app.Activity;
 import android.app.backup.BackupManager;
 import android.content.Context;
 import android.content.Intent;
@@ -115,12 +114,8 @@
             if (FeedbackUtils.isFeedbackFormSupported()) {
                 feedbackSettings.setOnPreferenceClickListener(new OnPreferenceClickListener() {
                     @Override
-                    public boolean onPreferenceClick(Preference arg0) {
-                        final Activity activity = getActivity();
-                        FeedbackUtils.showFeedbackForm(activity);
-                        if (!activity.isFinishing()) {
-                            activity.finish();
-                        }
+                    public boolean onPreferenceClick(final Preference pref) {
+                        FeedbackUtils.showFeedbackForm(getActivity());
                         return true;
                     }
                 });