commit 123407261cdab5d3eced0b18eaa7a1d59d6ae887
author Jean Chalard <jchalard@google.com> Thu Mar 15 14:37:40 2012 +0900
committer Jean Chalard <jchalard@google.com> Thu Mar 15 14:37:40 2012 +0900
tree f8a1dd1a75edada9155c8aea7723de4fdfaf1667
parent 3187ba5dfe4bd3c781bae01233314cbcd6e64dc5

Stop meaningless explicit null passing

Change-Id: I6950897d262f610d502b7f8293b9dd8d2b53e6e8

java/src/com/android/inputmethod/latin/SuggestedWords.java

diff --git a/java/src/com/android/inputmethod/latin/SuggestedWords.java b/java/src/com/android/inputmethod/latin/SuggestedWords.java
index 19967ef..82cfbbf 100644
--- a/java/src/com/android/inputmethod/latin/SuggestedWords.java
+++ b/java/src/com/android/inputmethod/latin/SuggestedWords.java
@@ -85,7 +85,7 @@
             final List<CharSequence> wordList) {
         final ArrayList<SuggestedWordInfo> result = new ArrayList<SuggestedWordInfo>();
         for (CharSequence word : wordList) {
-            if (null != word) result.add(new SuggestedWordInfo(word, null));
+            if (null != word) result.add(new SuggestedWordInfo(word));
         }
         return result;
     }
@@ -94,7 +94,7 @@
             final CompletionInfo[] infos) {
         final ArrayList<SuggestedWordInfo> result = new ArrayList<SuggestedWordInfo>();
         for (CompletionInfo info : infos) {
-            if (null != info) result.add(new SuggestedWordInfo(info.getText(), null));
+            if (null != info) result.add(new SuggestedWordInfo(info.getText()));
         }
         return result;
     }
@@ -105,14 +105,14 @@
             final CharSequence typedWord, final SuggestedWords previousSuggestions) {
         final ArrayList<SuggestedWordInfo> suggestionsList = new ArrayList<SuggestedWordInfo>();
         final HashSet<String> alreadySeen = new HashSet<String>();
-        suggestionsList.add(new SuggestedWordInfo(typedWord, null));
+        suggestionsList.add(new SuggestedWordInfo(typedWord));
         alreadySeen.add(typedWord.toString());
         final int previousSize = previousSuggestions.size();
         for (int pos = 1; pos < previousSize; pos++) {
             final String prevWord = previousSuggestions.getWord(pos).toString();
             // Filter out duplicate suggestion.
             if (!alreadySeen.contains(prevWord)) {
-                suggestionsList.add(new SuggestedWordInfo(prevWord, null));
+                suggestionsList.add(new SuggestedWordInfo(prevWord));
                 alreadySeen.add(prevWord);
             }
         }
@@ -130,15 +130,12 @@
 
         public SuggestedWordInfo(final CharSequence word, final CharSequence debugString) {
             mWord = word;
+            if (null == debugString) throw new NullPointerException("");
             mDebugString = debugString;
         }
 
         public String getDebugString() {
-            if (mDebugString == null) {
-                return "";
-            } else {
-                return mDebugString.toString();
-            }
+            return mDebugString.toString();
         }
 
         @Override