commit 024ee9ff0286b760a2c5aa7c755dda7e6c37ae21
author Jean Chalard <jchalard@google.com> Mon Dec 12 23:38:17 2011 -0800
committer Android (Google) Code Review <android-gerrit@google.com> Mon Dec 12 23:38:17 2011 -0800
tree 61069c4d6520c8c5a11b8c56e9781c5045327a8f
parent dc52e7c646bafb00898c3f2ebec064a5920e58fc
parent 2245c3b5b3691928b08fd6accf8d4a21fb35e26b

Merge changes I7888797c,I57b2232f

* changes:
  Refactor + small bugfix
  Refactoring

java/src/com/android/inputmethod/latin/LatinIME.java

diff --git a/java/src/com/android/inputmethod/latin/LatinIME.java b/java/src/com/android/inputmethod/latin/LatinIME.java
index 6ea642c..0299df4 100644
--- a/java/src/com/android/inputmethod/latin/LatinIME.java
+++ b/java/src/com/android/inputmethod/latin/LatinIME.java
@@ -1386,13 +1386,20 @@
 
     private void handleBackspace(final int spaceState) {
         if (mVoiceProxy.logAndRevertVoiceInput()) return;
-
         final InputConnection ic = getCurrentInputConnection();
         if (ic == null) return;
         ic.beginBatchEdit();
+        handleBackspaceWhileInBatchEdit(spaceState, ic);
+        ic.endBatchEdit();
+    }
 
+    // "ic" may not be null.
+    private void handleBackspaceWhileInBatchEdit(final int spaceState, final InputConnection ic) {
         mVoiceProxy.handleBackspace();
 
+        // In many cases, we may have to put the keyboard in auto-shift state again.
+        mHandler.postUpdateShiftKeyState();
+
         if (mEnteredText != null && sameAsTextBeforeCursor(ic, mEnteredText)) {
             // Cancel multi-character input: remove the text we just entered.
             // This is triggered on backspace after a key that inputs multiple characters,
@@ -1401,7 +1408,6 @@
             // If we have mEnteredText, then we know that mHasUncommittedTypedChars == false.
             // In addition we know that spaceState is false, and that we should not be
             // reverting any autocorrect at this point. So we can safely return.
-            ic.endBatchEdit();
             return;
         }
 
@@ -1430,21 +1436,15 @@
             } else {
                 ic.deleteSurroundingText(1, 0);
             }
-            // If we deleted the last remaining char of a word, we may have to put the keyboard
-            // in auto-shift state again.
-            mHandler.postUpdateShiftKeyState();
             // If we had uncommitted chars then we know it's not time to revert any auto-correct
             // and that spaceState is NONE.
-            ic.endBatchEdit();
             return;
         }
-        mHandler.postUpdateShiftKeyState();
 
         if (null != mWordSavedForAutoCorrectCancellation) {
             Utils.Stats.onAutoCorrectionCancellation();
             cancelAutoCorrect(ic);
             mWordSavedForAutoCorrectCancellation = null;
-            ic.endBatchEdit();
             return;
         } else {
             mWordSavedForAutoCorrectCancellation = null;
@@ -1452,14 +1452,12 @@
 
         if (SPACE_STATE_DOUBLE == spaceState) {
             if (revertDoubleSpace(ic)) {
-                ic.endBatchEdit();
                 // No need to reset mSpaceState, it has already be done (that's why we
                 // receive it as a parameter)
                 return;
             }
         } else if (SPACE_STATE_SWAP_PUNCTUATION == spaceState) {
             if (revertSwapPunctuation(ic)) {
-                ic.endBatchEdit();
                 // Likewise
                 return;
             }
@@ -1483,7 +1481,6 @@
                 restartSuggestionsOnWordBeforeCursorIfAtEndOfWord(ic);
             }
         }
-        ic.endBatchEdit();
     }
 
     private void handleTab() {