commit dcab1eafa3411d97d40eba9d6a97aa6dbfaa5a65
author Santiago Etchebehere <santie@google.com> Thu Jun 06 15:04:51 2019 -0700
committer Santiago Etchebehere <santie@google.com> Thu Jun 06 15:09:02 2019 -0700
tree 817fe6d334e6ead447a42be1838ebccf9da6a6a6
parent d3a582a98105430330383abd4f3e8b9bee6d9018

Correctly remove ViewPager views

We were not removing them from the parent in the adapter's
destroyItem method.

Bug: 134699139
Change-Id: Ida728182da06ba4b4dc148e82762070dd0b97771

src/com/android/customization/picker/BasePreviewAdapter.java

diff --git a/src/com/android/customization/picker/BasePreviewAdapter.java b/src/com/android/customization/picker/BasePreviewAdapter.java
index e87fb71..53f750a 100644
--- a/src/com/android/customization/picker/BasePreviewAdapter.java
+++ b/src/com/android/customization/picker/BasePreviewAdapter.java
@@ -88,7 +88,11 @@
     @Override
     public void destroyItem(@NonNull ViewGroup container, int position,
             @NonNull Object object) {
-        ((T) object).card = null;
+        View card = ((PreviewPage) object).card;
+        ((PreviewPage) object).card = null;
+        if (card.getParent() == container) {
+            container.removeView(card);
+        }
     }
 
     /**