commit 899f720e91d0a2bd025f83b94fd9efddf9185a25
author Catherine Liang <cathliang@google.com> Thu Apr 20 18:42:59 2023 +0000
committer Catherine Liang <cathliang@google.com> Thu Apr 20 19:41:01 2023 +0000
tree 8bc384323453f3560957953d20d62f3572b4d41d
parent 83dc77473e666e0cf2dee3cb6751dd1125da913f

Fix small gap between color option quadrants

Fix small gap by adjusting the constraint width and height of all the
quadrants to be slightly larger to prevent pixel differences that create
the appearnace of a gap.
Before: https://screenshot.googleplex.com/8YLAJFP9sLJjeMf.png
After: https://screenshot.googleplex.com/Bkg6iQQ2pTLtb8C.png

Bug: 278873537
Test: Manually verified
Change-Id: I354774d62ef17a714d7ea2b5b30ca2f6fdcc2a1c

res/layout/color_option_no_background.xml

diff --git a/res/layout/color_option_no_background.xml b/res/layout/color_option_no_background.xml
index b90b480..5416648 100644
--- a/res/layout/color_option_no_background.xml
+++ b/res/layout/color_option_no_background.xml
@@ -53,10 +53,10 @@
             android:layout_height="0dp"
             android:adjustViewBounds="true"
             android:src="@drawable/color_chip_seed_filled0"
-            app:layout_constraintHeight_percent=".50"
+            app:layout_constraintHeight_percent=".505"
             app:layout_constraintLeft_toLeftOf="parent"
             app:layout_constraintTop_toTopOf="parent"
-            app:layout_constraintWidth_percent=".50" />
+            app:layout_constraintWidth_percent=".505" />
 
         <ImageView
             android:id="@+id/color_preview_1"
@@ -64,10 +64,10 @@
             android:layout_height="0dp"
             android:adjustViewBounds="true"
             android:src="@drawable/color_chip_seed_filled2"
-            app:layout_constraintHeight_percent=".50"
-            app:layout_constraintLeft_toRightOf="@id/color_preview_0"
+            app:layout_constraintHeight_percent=".505"
+            app:layout_constraintRight_toRightOf="parent"
             app:layout_constraintTop_toTopOf="parent"
-            app:layout_constraintWidth_percent=".50" />
+            app:layout_constraintWidth_percent=".505" />
 
         <ImageView
             android:id="@+id/color_preview_2"
@@ -75,10 +75,10 @@
             android:layout_height="0dp"
             android:adjustViewBounds="true"
             android:src="@drawable/color_chip_seed_filled1"
-            app:layout_constraintHeight_percent=".50"
+            app:layout_constraintHeight_percent=".505"
             app:layout_constraintLeft_toLeftOf="parent"
-            app:layout_constraintTop_toBottomOf="@id/color_preview_0"
-            app:layout_constraintWidth_percent=".50" />
+            app:layout_constraintBottom_toBottomOf="parent"
+            app:layout_constraintWidth_percent=".505" />
 
         <ImageView
             android:id="@+id/color_preview_3"
@@ -86,10 +86,10 @@
             android:layout_height="0dp"
             android:adjustViewBounds="true"
             android:src="@drawable/color_chip_seed_filled3"
-            app:layout_constraintHeight_percent=".50"
-            app:layout_constraintLeft_toRightOf="@id/color_preview_2"
-            app:layout_constraintTop_toBottomOf="@id/color_preview_1"
-            app:layout_constraintWidth_percent=".50" />
+            app:layout_constraintHeight_percent=".505"
+            app:layout_constraintRight_toRightOf="parent"
+            app:layout_constraintBottom_toBottomOf="parent"
+            app:layout_constraintWidth_percent=".505" />
     </androidx.constraintlayout.widget.ConstraintLayout>
 
     <ImageView