Added more tests for color contrast changes
This CL aims at adding more tests for color contrast changes in
wallpaper picker.
Bug: 326108993
Test: Tested by building and installing picker on local
Flag: N/A
Change-Id: I3e22ac56f594225b96359e5ff09cfc589457fa75
diff --git a/src/com/android/customization/picker/settings/data/repository/ColorContrastSectionRepository.kt b/src/com/android/customization/picker/settings/data/repository/ColorContrastSectionRepository.kt
index 3986c78..b44b052 100644
--- a/src/com/android/customization/picker/settings/data/repository/ColorContrastSectionRepository.kt
+++ b/src/com/android/customization/picker/settings/data/repository/ColorContrastSectionRepository.kt
@@ -26,13 +26,13 @@
import kotlinx.coroutines.flow.Flow
import kotlinx.coroutines.flow.callbackFlow
-class ColorContrastSectionRepository(
+open class ColorContrastSectionRepository(
private val context: Context,
private val bgDispatcher: CoroutineDispatcher
) {
var uiModeManager =
context.applicationContext.getSystemService(UI_MODE_SERVICE) as UiModeManager?
- var contrast: Flow<Float> = callbackFlow {
+ open var contrast: Flow<Float> = callbackFlow {
val executor: Executor = bgDispatcher.asExecutor()
val listener =
UiModeManager.ContrastChangeListener { contrast ->
@@ -43,10 +43,8 @@
// Emit the current contrast value immediately
uiModeManager?.contrast?.let { currentContrast -> trySend(currentContrast) }
- // Register the listener with the UiModeManager
uiModeManager?.addContrastChangeListener(executor, listener)
- // Await close signals to unregister the listener to prevent memory leaks
awaitClose {
// Unregister the listener when the flow collection is cancelled or no longer in use
uiModeManager?.removeContrastChangeListener(listener)
diff --git a/src/com/android/customization/picker/settings/domain/interactor/ColorContrastSectionInteractor.kt b/src/com/android/customization/picker/settings/domain/interactor/ColorContrastSectionInteractor.kt
index 96ec5b8..91c0fa5 100644
--- a/src/com/android/customization/picker/settings/domain/interactor/ColorContrastSectionInteractor.kt
+++ b/src/com/android/customization/picker/settings/domain/interactor/ColorContrastSectionInteractor.kt
@@ -19,8 +19,8 @@
import com.android.customization.picker.settings.data.repository.ColorContrastSectionRepository
import kotlinx.coroutines.flow.Flow
-class ColorContrastSectionInteractor(
+open class ColorContrastSectionInteractor(
private val colorContrastSectionRepository: ColorContrastSectionRepository
) {
- val contrast: Flow<Float> = colorContrastSectionRepository.contrast
+ open val contrast: Flow<Float> = colorContrastSectionRepository.contrast
}
diff --git a/tests/robotests/src/com/android/customization/model/picker/settings/domain/interactor/ColorContrastSectionInteractorTest.kt b/tests/robotests/src/com/android/customization/model/picker/settings/domain/interactor/ColorContrastSectionInteractorTest.kt
new file mode 100644
index 0000000..b274b63
--- /dev/null
+++ b/tests/robotests/src/com/android/customization/model/picker/settings/domain/interactor/ColorContrastSectionInteractorTest.kt
@@ -0,0 +1,48 @@
+/*
+ * Copyright (C) 2024 The Android Open Source Project
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package com.android.customization.model.picker.settings.domain.interactor
+
+import androidx.test.filters.SmallTest
+import com.android.customization.picker.settings.data.repository.ColorContrastSectionRepository
+import com.android.customization.picker.settings.domain.interactor.ColorContrastSectionInteractor
+import kotlinx.coroutines.flow.first
+import kotlinx.coroutines.flow.flowOf
+import kotlinx.coroutines.test.runBlockingTest
+import org.junit.Assert.assertEquals
+import org.junit.Test
+import org.junit.runner.RunWith
+import org.mockito.Mockito.mock
+import org.mockito.kotlin.mock
+import org.mockito.kotlin.whenever
+import org.robolectric.RobolectricTestRunner
+
+@SmallTest
+@RunWith(RobolectricTestRunner::class)
+class ColorContrastSectionInteractorTest {
+
+ @Test
+ fun contrastEmitCorrectValuesFromRepository() = runBlockingTest {
+ val mockRepository: ColorContrastSectionRepository = mock()
+ val expectedContrast = 1.5f
+ whenever(mockRepository.contrast).thenReturn(flowOf(expectedContrast))
+ val interactor = ColorContrastSectionInteractor(mockRepository)
+
+ val result = interactor.contrast.first()
+
+ assertEquals(expectedContrast, result)
+ }
+}
diff --git a/tests/robotests/src/com/android/customization/model/picker/settings/ui/viewmodel/ColorContrastSectionViewModelTest.kt b/tests/robotests/src/com/android/customization/model/picker/settings/ui/viewmodel/ColorContrastSectionViewModelTest.kt
new file mode 100644
index 0000000..b77c017
--- /dev/null
+++ b/tests/robotests/src/com/android/customization/model/picker/settings/ui/viewmodel/ColorContrastSectionViewModelTest.kt
@@ -0,0 +1,116 @@
+/*
+ * Copyright (C) 2024 The Android Open Source Project
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package com.android.customization.model.picker.settings.ui.viewmodel
+
+import android.content.Context
+import androidx.test.core.app.ApplicationProvider
+import com.android.customization.picker.settings.domain.interactor.ColorContrastSectionInteractor
+import com.android.customization.picker.settings.ui.viewmodel.ColorContrastSectionDataViewModel
+import com.android.customization.picker.settings.ui.viewmodel.ColorContrastSectionViewModel
+import com.android.themepicker.R
+import com.android.wallpaper.picker.common.icon.ui.viewmodel.Icon
+import com.android.wallpaper.picker.common.text.ui.viewmodel.Text
+import kotlinx.coroutines.flow.collect
+import kotlinx.coroutines.flow.first
+import kotlinx.coroutines.flow.flowOf
+import kotlinx.coroutines.test.TestCoroutineDispatcher
+import kotlinx.coroutines.test.runBlockingTest
+import org.junit.Assert.assertEquals
+import org.junit.Before
+import org.junit.Test
+import org.junit.runner.RunWith
+import org.mockito.kotlin.doReturn
+import org.mockito.kotlin.mock
+import org.robolectric.RobolectricTestRunner
+
+@RunWith(RobolectricTestRunner::class)
+class ColorContrastSectionViewModelTest {
+ private lateinit var bgDispatcher: TestCoroutineDispatcher
+ private lateinit var context: Context
+ private lateinit var viewModel: ColorContrastSectionViewModel
+ private lateinit var interactor: ColorContrastSectionInteractor
+
+ @Before
+ fun setUp() {
+ context = ApplicationProvider.getApplicationContext<Context>()
+ bgDispatcher = TestCoroutineDispatcher()
+ }
+
+ @Test
+ fun summaryEmitsCorrectDataValueForStandard() = runBlockingTest {
+ interactor = mock {
+ on { contrast } doReturn
+ flowOf(ColorContrastSectionViewModel.ContrastValue.STANDARD.value)
+ }
+ val factory = ColorContrastSectionViewModel.Factory(interactor)
+ viewModel = factory.create(ColorContrastSectionViewModel::class.java)
+
+ val expected =
+ ColorContrastSectionDataViewModel(
+ Text.Resource(R.string.color_contrast_default_title),
+ Icon.Resource(res = R.drawable.ic_contrast_standard, contentDescription = null)
+ )
+
+ val result = viewModel.summary.first()
+ assertEquals(expected, result)
+ }
+
+ @Test
+ fun summaryEmitsCorrectDataValueForMedium() = runBlockingTest {
+ interactor = mock {
+ on { contrast } doReturn
+ flowOf(ColorContrastSectionViewModel.ContrastValue.MEDIUM.value)
+ }
+ val factory = ColorContrastSectionViewModel.Factory(interactor)
+ viewModel = factory.create(ColorContrastSectionViewModel::class.java)
+
+ val expected =
+ ColorContrastSectionDataViewModel(
+ Text.Resource(R.string.color_contrast_medium_title),
+ Icon.Resource(res = R.drawable.ic_contrast_medium, contentDescription = null)
+ )
+
+ val result = viewModel.summary.first()
+ assertEquals(expected, result)
+ }
+
+ @Test
+ fun summaryEmitsCorrectDataValueForHigh() = runBlockingTest {
+ interactor = mock {
+ on { contrast } doReturn flowOf(ColorContrastSectionViewModel.ContrastValue.HIGH.value)
+ }
+ val factory = ColorContrastSectionViewModel.Factory(interactor)
+ viewModel = factory.create(ColorContrastSectionViewModel::class.java)
+
+ val expected =
+ ColorContrastSectionDataViewModel(
+ Text.Resource(R.string.color_contrast_high_title),
+ Icon.Resource(res = R.drawable.ic_contrast_high, contentDescription = null)
+ )
+
+ val result = viewModel.summary.first()
+ assertEquals(expected, result)
+ }
+
+ @Test(expected = IllegalArgumentException::class)
+ fun summaryThrowsIllegalArgumentExceptionForInvalidValue() = runBlockingTest {
+ interactor = mock { on { contrast } doReturn flowOf(999f) }
+ val factory = ColorContrastSectionViewModel.Factory(interactor)
+ viewModel = factory.create(ColorContrastSectionViewModel::class.java)
+ viewModel.summary.collect() // This should throw an IllegalArgumentException
+ }
+}