| commit | 45308198182b9702066df5c9baf5c2d36e4d0c15 | [log] [tgz] |
|---|---|---|
| author | Dave Mankoff <mankoff@google.com> | Mon Nov 11 18:12:03 2024 +0000 |
| committer | Dave Mankoff <mankoff@google.com> | Mon Nov 11 21:15:54 2024 +0000 |
| tree | 021012485006d78204e8aee5f4f43d988d318205 | |
| parent | 2ecb7cf498bd6bb4c7ca2f718190194d054031af [diff] |
Replace field injection with constructor injection. Change-Id: I86ef6b5a23777bd9531d13e2d6b86b3c0f981e80 --- THIS CL MAY BRIEFLY, INTENTIONALLY, BREAK THE BUILD. This CL corresponds with two CLs in aosp: https://r.android.com/q/topic:%22k2-upgrade-wpp%22 Once all three CLs are in, the build will straighten itself out. It is not currenlty possible to submit all three atomically, thus the possibility of a broken build. PLEASE BE PATIENT BEFORE REVERTING. If all three CLs are merged, please wait an hour to see if the build goes green before reverting. --- This fixes an issue we are having with an upgrade to Kotlin 2.0.21. See the presubmits on https://r.android.com/3290825. Generally, field injection should be avoided in favor of constructor injection, so hopefully this is a change for the better. Bug: 369137871 Flag: EXEMPT Minor refactor Test: m ThemePickerApplicationLib (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:65d5aa7e1169340dd1be22d892ba26a34050eb52) Merged-In: I718113e103da303ddfb102b73c95f9a9b25da132 Change-Id: I718113e103da303ddfb102b73c95f9a9b25da132 Change-Id: I458c01e4b1a22d6732d1e16321903d127150cba6