commit eb4575e8c256885ba845e773d7e9e09b99a73a65
author Derek Tan <derektan@google.com> Fri Apr 25 16:47:54 2014 -0700
committer Derek Tan <derektan@google.com> Sat Apr 26 00:15:59 2014 +0000
tree 46edbe9998d416eb793e6ce5f661abd27ba95033
parent 1102f76e5852d4cc482264e67c52cabf85d7a51d

Fix the crash of BandMode app.

It crashes because of out of array boundary exception. This app
predefined a list of constant strings of band mode. Unfortunately
the actual supported band modes keep adding and the hardcoded
list can meet.

Change-Id: Ife9683924706a1606d4f72b01a5904e9aa0f782c

src/com/android/settings/BandMode.java

diff --git a/src/com/android/settings/BandMode.java b/src/com/android/settings/BandMode.java
index 0a0f77f..81e8b49 100644
--- a/src/com/android/settings/BandMode.java
+++ b/src/com/android/settings/BandMode.java
@@ -58,7 +58,7 @@
         super.onCreate(icicle);
 
         requestWindowFeature(Window.FEATURE_INDETERMINATE_PROGRESS);
-        
+
         setContentView(R.layout.band_mode);
 
         setTitle(getString(R.string.band_mode_title));
@@ -73,8 +73,6 @@
         mBandList.setAdapter(mBandListAdapter);
         mBandList.setOnItemClickListener(mBandSelectionHandler);
 
-
-
         loadBandList();
     }
 
@@ -109,6 +107,7 @@
         }
 
         public String toString() {
+            if (mBandMode >= BAND_NAMES.length) return "Band mode " + mBandMode;
             return BAND_NAMES[mBandMode];
         }
     }