commit c101d2d3babd9e456666e6dbc87e7aefa6d27795
author Amith Yamasani <yamasani@google.com> Fri Nov 11 13:25:07 2011 -0800
committer Amith Yamasani <yamasani@google.com> Mon Nov 14 15:30:16 2011 -0800
tree 4781690eda76c977048fa0d9e52a22623fbdd1da
parent 4b94e073854b72205f12ff268211a51d634fbc8f

Dismiss dialogs properly on closing.

Also make the invisible activity truly invisible (was
showing a blue line behind the dialog).

Bug: 5572140
Change-Id: I67b31f0682f189c7075011e0dd0660b0fbc543d9

AndroidManifest.xml

diff --git a/AndroidManifest.xml b/AndroidManifest.xml
index 649e06c..68aca79 100644
--- a/AndroidManifest.xml
+++ b/AndroidManifest.xml
@@ -494,7 +494,7 @@
 
         <activity android:name="SettingsLicenseActivity"
                 android:label="@string/settings_license_activity_title"
-                android:theme="@*android:style/Theme.Holo.Dialog.Alert"
+                android:theme="@android:style/Theme.Holo.Panel"
                 android:configChanges="orientation|screenSize">
             <intent-filter>
                 <action android:name="android.settings.LICENSE" />

src/com/android/settings/SettingsLicenseActivity.java

diff --git a/src/com/android/settings/SettingsLicenseActivity.java b/src/com/android/settings/SettingsLicenseActivity.java
index 2960180..b9efa72 100644
--- a/src/com/android/settings/SettingsLicenseActivity.java
+++ b/src/com/android/settings/SettingsLicenseActivity.java
@@ -173,10 +173,13 @@
 
     @Override
     protected void onDestroy() {
-        super.onDestroy();
-        if (mTextDlg != null) {
+        if (mTextDlg != null && mTextDlg.isShowing()) {
             mTextDlg.dismiss();
         }
+        if (mSpinnerDlg != null && mSpinnerDlg.isShowing()) {
+            mSpinnerDlg.dismiss();
+        }
+        super.onDestroy();
     }
 
     private void showPageOfText(String text) {
@@ -200,9 +203,7 @@
             @Override
             public void onPageFinished(WebView view, String url) {
                 mSpinnerDlg.dismiss();
-                mSpinnerDlg = null;
                 mTextDlg.show();
-                mTextDlg = null;
             }
         });