commit bd482c986c288aa8f2f382961cc441692d821adc
author Weng Su <wengsu@google.com> Wed Nov 11 07:57:44 2020 +0000
committer Weng Su <wengsu@google.com> Thu Nov 12 08:44:14 2020 +0000
tree 83bbb26b323bd7a29533907ed2bb4e07d37cb63a
parent 76eb40191119f6524566010cf3dcd56aa266dcdf

Add a mutability flag to the PendingIntent

- Request from Android Platform Security team.
  go/immutable-pendingintents

Bug: 170162129
Test:
1. adb shell am start -a
android.settings.panel.action.INTERNET_CONNECTIVITY
2. make RunSettingsRoboTests ROBOTEST_FILTER=WifiSliceTest
Change-Id: If3032959649206f2fb6736244d7aa8b9a8419378

src/com/android/settings/wifi/slice/WifiSlice.java

diff --git a/src/com/android/settings/wifi/slice/WifiSlice.java b/src/com/android/settings/wifi/slice/WifiSlice.java
index 324d68c..2858ab4 100644
--- a/src/com/android/settings/wifi/slice/WifiSlice.java
+++ b/src/com/android/settings/wifi/slice/WifiSlice.java
@@ -224,7 +224,7 @@
     private SliceAction getActivityAction(int requestCode, Intent intent, IconCompat icon,
             CharSequence title) {
         final PendingIntent pi = PendingIntent.getActivity(mContext, requestCode, intent,
-                0 /* flags */);
+                PendingIntent.FLAG_IMMUTABLE /* flags */);
         return SliceAction.createDeeplink(pi, icon, ListBuilder.ICON_IMAGE, title);
     }
 
@@ -289,7 +289,7 @@
     private PendingIntent getPrimaryAction() {
         final Intent intent = getIntent();
         return PendingIntent.getActivity(mContext, 0 /* requestCode */,
-                intent, 0 /* flags */);
+                intent, PendingIntent.FLAG_IMMUTABLE /* flags */);
     }
 
     private Set<String> getKeywords() {