commit b8955defaf11d6ba1138f86a6473cac6ca6275d5
author Daniel Sandler <dsandler@google.com> Mon Mar 08 12:10:39 2010 -0800
committer Android (Google) Code Review <android-gerrit@google.com> Mon Mar 08 12:10:39 2010 -0800
tree 2c4e30101e814a3fcc0e816937f7812c5ec9ee64
parent cc06afa605bfd80ed7dca7e61863163f305e5eeb
parent 4ce4f759bd3979de4b21e66a0f8c7ec2beb40a31

Merge "Fix vibrate settings for incoming calls."

src/com/android/settings/UserDictionarySettings.java

diff --git a/src/com/android/settings/UserDictionarySettings.java b/src/com/android/settings/UserDictionarySettings.java
index 4b30b53..6ffcb3d 100644
--- a/src/com/android/settings/UserDictionarySettings.java
+++ b/src/com/android/settings/UserDictionarySettings.java
@@ -159,7 +159,8 @@
         
         AdapterContextMenuInfo adapterMenuInfo = (AdapterContextMenuInfo) menuInfo;
         String word = getWord(adapterMenuInfo.position);
-        
+        if (word == null) return true;
+
         switch (item.getItemId()) {
             case CONTEXT_MENU_DELETE:
                 deleteWord(word);
@@ -193,6 +194,9 @@
     
     private String getWord(int position) {
         mCursor.moveToPosition(position);
+        // Handle a possible race-condition
+        if (mCursor.isAfterLast()) return null;
+
         return mCursor.getString(
                 mCursor.getColumnIndexOrThrow(UserDictionary.Words.WORD));
     }

src/com/android/settings/wifi/WifiApDialog.java

diff --git a/src/com/android/settings/wifi/WifiApDialog.java b/src/com/android/settings/wifi/WifiApDialog.java
index 485e54e..7053d72 100644
--- a/src/com/android/settings/wifi/WifiApDialog.java
+++ b/src/com/android/settings/wifi/WifiApDialog.java
@@ -108,11 +108,10 @@
         return null;
     }
 
-    @Override
     protected void onCreate(Bundle savedInstanceState) {
 
-        Spinner mSecurity = ((Spinner) mView.findViewById(R.id.security));
         mView = getLayoutInflater().inflate(R.layout.wifi_ap_dialog, null);
+        Spinner mSecurity = ((Spinner) mView.findViewById(R.id.security));
 
         setView(mView);
         setInverseBackgroundForced(true);