commit b6fa43d9803511dc7a08cf0f8e89bd6a37c33e9e
author xiyuan.wang <xiyuan.wang@sony.com> Fri Oct 20 17:59:58 2017 +0800
committer Yoshinori Hirano <Yoshinori.Hirano@sony.com> Mon Oct 30 19:55:56 2017 +0900
tree e2dfb630654a1a206703d8032f897d961fd29a6f
parent 3d8b442e8d355172418b95665a099f8e803a72d0

Fix app crash while adding new user

Settings app crashes when tapping Home key while adding new user because
UserSettings#showDialog() is called after onSaveInstanceState().
To fix this issue, a dialog should not be shown after onPause().

Fixes: 68485787
Test: manual - tap Home key while adding new user

Change-Id: I2ddd119b6558927798a52c7977e6fd8137734c93

src/com/android/settings/users/UserSettings.java

diff --git a/src/com/android/settings/users/UserSettings.java b/src/com/android/settings/users/UserSettings.java
index bef2e9a..ec055f1 100644
--- a/src/com/android/settings/users/UserSettings.java
+++ b/src/com/android/settings/users/UserSettings.java
@@ -450,6 +450,10 @@
     private void onUserCreated(int userId) {
         mAddedUserId = userId;
         mAddingUser = false;
+        if (!isResumed()) {
+            Log.w(TAG, "Cannot show dialog after onPause");
+            return;
+        }
         if (mUserManager.getUserInfo(userId).isRestricted()) {
             showDialog(DIALOG_SETUP_PROFILE);
         } else {