commit a8ac78b3925a0b463c2df37a7c83d8f15222a601
author Fabrice Di Meglio <fdimeglio@google.com> Wed May 28 15:56:30 2014 -0700
committer Fabrice Di Meglio <fdimeglio@google.com> Wed May 28 15:56:30 2014 -0700
tree 51dfa8199124e91edab2f80da42c0afc8d264f06
parent c75417a75864f0fe1a4837c2cc3347cd1d8d83c5

Search - prepare for better normalization

- code refactoring

See bug: #15314612 Search - need to be able to search and have results
with non accentuated chars

Change-Id: Ic3eb94c0effccf6592c02b3eaa78bf26a2d09714

src/com/android/settings/search/Index.java

diff --git a/src/com/android/settings/search/Index.java b/src/com/android/settings/search/Index.java
index adddb39..64ef985 100644
--- a/src/com/android/settings/search/Index.java
+++ b/src/com/android/settings/search/Index.java
@@ -914,31 +914,13 @@
             String intentAction, String intentTargetPackage, String intentTargetClass,
             boolean enabled, String key) {
 
-        String updatedTitle;
-        if (title != null) {
-            updatedTitle = title.replaceAll(NON_BREAKING_HYPHEN, HYPHEN);
-        }
-        else {
-            updatedTitle = EMPTY;
-        }
+        String updatedTitle = normalizeHyphen(title);
+        String updatedSummaryOn = normalizeHyphen(summaryOn);
+        String updatedSummaryOff = normalizeHyphen(summaryOff);
 
-        String updatedSummaryOn;
-        if (summaryOn != null) {
-            updatedSummaryOn = summaryOn.replaceAll(NON_BREAKING_HYPHEN, HYPHEN);
-        } else {
-            updatedSummaryOn = EMPTY;
-        }
-
-        String updatedSummaryOff;
-        if (summaryOff != null) {
-            updatedSummaryOff = summaryOff.replaceAll(NON_BREAKING_HYPHEN, HYPHEN);
-        } else {
-            updatedSummaryOff = EMPTY;
-        }
-
-        String normalizedTitle = updatedTitle.replaceAll(HYPHEN, EMPTY);
-        String normalizedSummaryOn = updatedSummaryOn.replaceAll(HYPHEN, EMPTY);
-        String normalizedSummaryOff = updatedSummaryOff.replaceAll(HYPHEN, EMPTY);
+        String normalizedTitle = normalizeString(updatedTitle);
+        String normalizedSummaryOn = normalizeString(updatedSummaryOn);
+        String normalizedSummaryOff = normalizeString(updatedSummaryOff);
 
         updateOneRow(database, locale,
                 updatedTitle, normalizedTitle, updatedSummaryOn, normalizedSummaryOn,
@@ -947,6 +929,14 @@
                 rank, keywords, intentAction, intentTargetPackage, intentTargetClass, enabled, key);
     }
 
+    private static String normalizeHyphen(String input) {
+        return (input != null) ? input.replaceAll(NON_BREAKING_HYPHEN, HYPHEN) : EMPTY;
+    }
+
+    private static String normalizeString(String input) {
+        return (input != null) ? input.replaceAll(HYPHEN, EMPTY) : EMPTY;
+    }
+
     private void updateOneRow(SQLiteDatabase database, String locale,
             String updatedTitle, String normalizedTitle,
             String updatedSummaryOn, String normalizedSummaryOn,